Skip to content

Max drop limit for TelemetryEventBuffer after which we completely drop events #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sl0thentr0py merged 2 commits into from
Jan 13, 2026
Merged

Max drop limit for TelemetryEventBuffer after which we completely drop events #2831

sl0thentr0py merged 2 commits into from
Jan 13, 2026

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jan 13, 2026

Description

  • This is mainly to protect from memory blowup in high throughput scenarios
  • We record queue_overflow client reports in this case
  • Also raised the Metric buffer limits to 1k/10k as compared to 100/1k for logs (consistent with Python)

Issues

@linear
Copy link

linear bot commented Jan 13, 2026

RUBY-132 Ensure maximum cap on logs and metrics buffers

@sl0thentr0py sl0thentr0py force-pushed the neel/telemetry-buffer-max-cap branch from ea175f2 to 1469f60 Compare January 13, 2026 11:34
@sl0thentr0py sl0thentr0py changed the title Have a higher max limit for TelemetryEventBuffer after which we completely drop events Max drop limit for TelemetryEventBuffer after which we completely drop events Jan 13, 2026
@sl0thentr0py sl0thentr0py force-pushed the neel/telemetry-buffer-max-cap branch from 1469f60 to ce9fcb9 Compare January 13, 2026 11:36
@sl0thentr0py sl0thentr0py requested a review from solnic January 13, 2026 11:41
cursor[bot]
cursor bot reviewed Jan 13, 2026
View reviewed changes
@sl0thentr0py sl0thentr0py force-pushed the neel/telemetry-buffer-max-cap branch from ce9fcb9 to b613ba7 Compare January 13, 2026 11:44
@sl0thentr0py
Have a higher max limit for TelemetryEventBuffer after which we
e8708aa 
completely drop events

* This is mainly to protect from memory blowup in high throughput
  scenarios
* Also raised the Metric buffer limits to 1k/10k as compared to 100/1k
  for logs (consistent with Python)
@sl0thentr0py sl0thentr0py force-pushed the neel/telemetry-buffer-max-cap branch from b613ba7 to e8708aa Compare January 13, 2026 11:44
solnic
solnic requested changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fixes needed

@sl0thentr0py sl0thentr0py merged commit 8db45ed into master Jan 13, 2026
136 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/telemetry-buffer-max-cap branch January 13, 2026 14:19
@github-actions github-actions bot mentioned this pull request Jan 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@solnic solnic solnic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure maximum cap on logs and metrics buffers

3 participants

@sl0thentr0py @solnic