feat: add support for symfony 8 #968
Conversation
|
Last week sentry-php released a new version compatible with Symfony 8. You should try re-running the CI |
|
@garak I pinned the version to |
And why did you pin it? |
My mistake, I wanted to say bumped |
|
Hi, any idea if the support for Symfony 8 will be added to the 4.x branch ? Thanks in advance. |
I'm afraid it will not be added. Could you tell us what prevents you from upgrading to 5.x? Maybe we can find a solution for that |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
composer.json
Outdated
| "keywords": ["logging", "errors", "symfony", "sentry"], | ||
| "homepage": "http://getsentry.com", | ||
| "minimum-stability": "dev", | ||
| "prefer-stable": false, |
There was a problem hiding this comment.
Bug: Incorrect prefer-stable setting causes unstable dependency resolution
The prefer-stable setting is set to false, which tells Composer to prefer unstable package versions over stable ones. Combined with minimum-stability: dev, this could cause Composer to install dev/beta/alpha versions of all dependencies even when stable releases exist. To support Symfony 8 beta while keeping other dependencies stable, prefer-stable needs to be true (which is actually Composer's default when not specified). With the current setting, projects installing this bundle may get unexpected unstable versions of transitive dependencies.
Unfortunately, no. My company is stuck with an old Sentry in version 8.21.0, which we can use only with sentry-symfony in version 4. |
Our SaaS service sentry.io now offers EU data locality (Germany to be precise). Sentry 8.21.0 came out in Oct 2017, with the required minimum self-hosted version being released in Jun, 2020. |
|
Last test is blocked by doctrine/DoctrineBundle#1910 |
|
Thanks @greg0ire! |
getsentry#968 migrated the service definitions from XML to YAML, however, the bundle only declares the YAML component as a development dependency. This causes the bundle's services to not be loaded if an application does not have the component installed, therefore, the YAML component is now a production dependency of the bundle.
getsentry#968 migrated the service definitions from XML to YAML, however, the bundle only declares the YAML component as a development dependency. This causes the bundle's services to not be loaded if an application does not have the component installed, therefore, the YAML component is now a production dependency of the bundle.
We need to cleanup
composer.jsonand the CI config once Symfony 8 is properly released to use the stable version instead ofBETAbefore merging this.