Skip to content

fix: Remove usage of deprecated CGWindowListCreateImage function on Mac #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Remove usage of deprecated CGWindowListCreateImage function on Mac #1034

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
695aa29
Use the Screenshot utils to capture Screenshot on Mac, fixing depreca…
mujacica Aug 5, 2025
5139473
Format code
getsentry-bot Aug 5, 2025
4d184ea
Update Changelog
mujacica Aug 5, 2025
263cffa
Only send Screenshot Path when capturing was successful
mujacica Aug 5, 2025
8270182
Format code
getsentry-bot Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 3 additions & 35 deletions plugin-dev/Source/Sentry/Private/Mac/MacSentrySubsystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "SentrySettings.h"

#include "Utils/SentryFileUtils.h"
#include "Utils/SentryScreenshotUtils.h"

#include "Misc/CoreDelegates.h"
#include "Misc/FileHelper.h"
Expand Down Expand Up @@ -42,41 +43,8 @@ TSharedPtr<ISentryId> FMacSentrySubsystem::CaptureEnsure(const FString& type, co

FString FMacSentrySubsystem::TryCaptureScreenshot() const
{
NSWindow* MainWindow = [NSApp mainWindow];
if (!MainWindow)
{
UE_LOG(LogSentrySdk, Error, TEXT("No main window found!"));
return FString("");
}

NSRect WindowRect = [MainWindow frame];
CGWindowID WindowID = (CGWindowID)[MainWindow windowNumber];
CGImageRef ScreenshotRef = CGWindowListCreateImage(WindowRect, kCGWindowListOptionIncludingWindow, WindowID, kCGWindowImageDefault);

if (!ScreenshotRef)
{
UE_LOG(LogSentrySdk, Error, TEXT("Failed to capture screenshot - invalid ScreenshotRef."));
return FString("");
}

NSBitmapImageRep* BitmapRep = [[NSBitmapImageRep alloc] initWithCGImage:ScreenshotRef];
NSData* ImageData = [BitmapRep representationUsingType:NSBitmapImageFileTypePNG properties:@{}];

TArray<uint8> ImageBytes;
uint32 SavedSize = (uint32)[ImageData length];
ImageBytes.AddUninitialized(SavedSize);
FPlatformMemory::Memcpy(ImageBytes.GetData(), [ImageData bytes], SavedSize);

CGImageRelease(ScreenshotRef);

FString ScreenshotPath = GetScreenshotPath();

if (!FFileHelper::SaveArrayToFile(ImageBytes, *ScreenshotPath))
{
UE_LOG(LogSentrySdk, Error, TEXT("Failed to save screenshot to: %s"), *ScreenshotPath);
return FString("");
}

const FString ScreenshotPath = GetScreenshotPath();
SentryScreenshotUtils::CaptureScreenshot(ScreenshotPath);
return ScreenshotPath;
}

Expand Down
Loading