chore(test): Clean up e2e test utils #1182
Merged
+157
−250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a final PR to our migration to
cliftyin all e2e tests, this one cleans up and streamlines our internal e2e test utils:startWizardInstancemade obsolete bycliftyWizardTestEnvto a smallerProcessRunnerabstraction. This class previously had two purposes:cliftyProcessRunnercheckPackageJsoncheck to actually ensure that a package is listed as a dependency and not just somewhere mentioned inpackage.json. Also removed the unnecessary Integration -> packageName mapping in the process.