Skip to content

ci(release): Switch from action-prepare-release to Craft #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 16 commits into from
Jan 15, 2026
Merged

ci(release): Switch from action-prepare-release to Craft #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
457657c
ci(release): Switch from action-prepare-release to Craft
BYK Jan 9, 2026
3f083b5
ci(release): Restore GitHub App token authentication
BYK Jan 9, 2026
ef35d36
fix: Pin actions to SHA and add permissions blocks
BYK Jan 10, 2026
3c21d28
fix: Use correct action version SHAs (restore original versions)
BYK Jan 10, 2026
fb58376
fix: Use correct action version SHAs (restore original versions)
BYK Jan 10, 2026
f81f045
fix: Restore missing setup steps (Node.js/uv/Rust/pnpm)
BYK Jan 10, 2026
99131d2
fix: Clean up action version comments
BYK Jan 12, 2026
4ae79d7
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK Jan 13, 2026
5be213a
Add explicit permissions block to build.yml
BYK Jan 13, 2026
dc8b381
Add explicit permissions block to codeql-analysis.yml
BYK Jan 13, 2026
ed8da68
Revert permissions changes to build.yml
BYK Jan 13, 2026
2a556cf
Revert permissions changes to codeql-analysis.yml
BYK Jan 13, 2026
394543e
fix: clean up release.yml formatting and version comments
BYK Jan 14, 2026
3f326ab
build(craft): Update Craft action to c6e2f04
BYK Jan 14, 2026
51f186d
Apply suggestion from @BYK
BYK Jan 14, 2026
1fcd80e
chore: add unlabeled trigger to changelog-preview
BYK Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/changelog-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
pull_request:
types: [opened, synchronize, reopened, edited, labeled]

permissions:
contents: read
pull-requests: write

jobs:
changelog-preview:
uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ on:
workflow_dispatch:
inputs:
version:
description: Version to release
required: true
description: Version to release (or "auto")
required: false
force:
description:
Force a release even when there are release-blockers (optional)
Expand All @@ -15,6 +15,10 @@ on:
(optional)
required: false
default: master
permissions:
contents: write
pull-requests: write

jobs:
release:
runs-on: ubuntu-latest
Expand All @@ -33,7 +37,7 @@ jobs:
- name: Install Dependencies
run: yarn install
- name: Prepare release
uses: getsentry/action-prepare-release@v1
uses: getsentry/craft@c6e2f04939b6ee67030588afbb5af76b127d8203 # v2
Copy link

@sentry sentry bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The version input for the release workflow is optional. If not provided, it passes an empty string to the craft action, which may cause the workflow to fail.
Severity: MEDIUM

Suggested Fix

To prevent potential failures, provide a default value for the version input. For example, setting default: 'auto' would align with the input's description and ensure the craft action receives a valid, expected value when the input is not manually specified.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/release.yml#L40

Potential issue: In the `release.yml` workflow, the `version` input is now optional
(`required: false`) and lacks a default value. When this workflow is triggered manually
without providing a version, GitHub Actions passes an empty string (`''`) to the
`getsentry/craft` action. It is uncertain if the `craft` action is designed to handle an
empty string for its `version` parameter. If it is not, this could cause the release
process to fail when a version is not explicitly provided during a manual trigger.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Member

@Lms24 Lms24 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BYK I believe this is no longer required because the action would determine the release automatically, unless manually specified, correct?

env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
with:
Expand Down
Loading