Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"devDependencies": {
"@sveltejs/adapter-node": "^5.3.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The test application updates @sveltejs/kit to 2.49.5 but leaves @sveltejs/vite-plugin-svelte at ^4.0.0, which is likely an incompatible combination that will cause build failures.
Severity: HIGH

Suggested Fix

Update the @sveltejs/vite-plugin-svelte dependency to a version compatible with @sveltejs/[email protected]. Based on other test applications in the repository, version ^3.0.0 is the likely correct choice. Alternatively, confirm through testing that version ^4.0.0 is indeed compatible.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: e2e-tests/test-applications/sveltekit-tracing-test-app/package.json#L13

Potential issue: The `package.json` for the `sveltekit-tracing-test-app` updates
`@sveltejs/kit` to version `2.49.5` but does not adjust the version of
`@sveltejs/vite-plugin-svelte`, which remains at `^4.0.0`. There is evidence of a peer
dependency mismatch, as SvelteKit 2.x versions typically require
`vite-plugin-svelte@^3.0.0`. This incompatibility is likely to cause the `vite build`
step to fail within the E2E test suite. Since the purpose of this test is to validate
the Sentry wizard's setup, a build failure would prevent the verification of the
wizard's functionality with this SvelteKit version, rendering the test ineffective.

Did we get this right? 👍 / 👎 to inform future reviews.

"@sveltejs/kit": "2.31.0",
"@sveltejs/kit": "2.49.5",
"@sveltejs/vite-plugin-svelte": "^4.0.0",
"svelte": "^5.0.0",
"svelte-check": "^4.0.0",
Expand Down
Loading