ref(nuxt): Remove option to downgrade override nitropack #744
+3
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I kept the
@vercel/nftoverride in without a version check because checking if a dependency of a dependency is installed is not super straight forward. I previously used https://github.com/browserify/resolve to check, but it requires dependencies to be installed - which they might not be yet at the point in time when we want to add overrides.The alternative would be to run the install command for users again, which also seemed suboptimal.
So I opted to keep the override for
@vercel/nftregardless of whether nitro is already over2.10.0.Closes: #736