ref(eslint): prefer-arrow-callback for anonymous callback functions (#97853)

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Author: TkDodo

eslint.config.mjs

@@ -355,6 +355,7 @@ export default typescript.config([
       'no-sequences': 'error',
       'no-throw-literal': 'error',
       'object-shorthand': ['error', 'properties'],
+      'prefer-arrow-callback': ['error', {allowNamedFunctions: true}],
       radix: 'error',
       'require-await': 'error', // Enabled in favor of @typescript-eslint/require-await, which requires type info
       'spaced-comment': [

static/app/actionCreators/account.spec.tsx

@@ -5,7 +5,7 @@ import {testableWindowLocation} from 'sentry/utils/testableWindowLocation';
 import {logout} from './account';
 
 describe('logout', () => {
-  it('has can logout', async function () {
+  it('has can logout', async () => {
     const mockApi = new MockApiClient();
     const mockApiDelete = MockApiClient.addMockResponse({
       url: '/auth/',

static/app/actionCreators/events.spec.tsx

@@ -3,7 +3,7 @@ import {ProjectFixture} from 'sentry-fixture/project';
 
 import {doEventsRequest} from 'sentry/actionCreators/events';
 
-describe('Events ActionCreator', function () {
+describe('Events ActionCreator', () => {
   const api = new MockApiClient();
   const organization = OrganizationFixture();
   const project = ProjectFixture();
@@ -15,7 +15,7 @@ describe('Events ActionCreator', function () {
 
   let mock: jest.Mock;
 
-  beforeEach(function () {
+  beforeEach(() => {
     MockApiClient.clearMockResponses();
     mock = MockApiClient.addMockResponse({
       url: '/organizations/org-slug/events-stats/',
@@ -32,7 +32,7 @@ describe('Events ActionCreator', function () {
     });
   });
 
-  it('requests events stats with relative period', async function () {
+  it('requests events stats with relative period', async () => {
     await doEventsRequest<false>(api, {
       ...opts,
       includeAllArgs: false,
@@ -53,7 +53,7 @@ describe('Events ActionCreator', function () {
     );
   });
 
-  it('requests events stats with relative period including previous period', async function () {
+  it('requests events stats with relative period including previous period', async () => {
     await doEventsRequest<false>(api, {
       ...opts,
       includeAllArgs: false,
@@ -74,7 +74,7 @@ describe('Events ActionCreator', function () {
     );
   });
 
-  it('requests events stats with absolute period', async function () {
+  it('requests events stats with absolute period', async () => {
     const start = new Date('2017-10-12T12:00:00.000Z');
     const end = new Date('2017-10-17T00:00:00.000Z');
     await doEventsRequest<false>(api, {
@@ -100,7 +100,7 @@ describe('Events ActionCreator', function () {
     );
   });
 
-  it('requests events stats with absolute period including previous period', async function () {
+  it('requests events stats with absolute period including previous period', async () => {
     const start = new Date('2017-10-12T12:00:00.000Z');
     const end = new Date('2017-10-17T00:00:00.000Z');
     await doEventsRequest<false>(api, {
@@ -125,7 +125,7 @@ describe('Events ActionCreator', function () {
     );
   });
 
-  it('spreads query extras', async function () {
+  it('spreads query extras', async () => {
     await doEventsRequest<false>(api, {
       ...opts,
       includeAllArgs: false,

static/app/actionCreators/group.spec.tsx

@@ -2,8 +2,8 @@ import {bulkUpdate, mergeGroups, paramsToQueryArgs} from 'sentry/actionCreators/
 import GroupStore from 'sentry/stores/groupStore';
 
 describe('group', () => {
-  describe('paramsToQueryArgs()', function () {
-    it('should convert itemIds properties to id array', function () {
+  describe('paramsToQueryArgs()', () => {
+    it('should convert itemIds properties to id array', () => {
       expect(
         paramsToQueryArgs({
           itemIds: ['1', '2', '3'],
@@ -12,7 +12,7 @@ describe('group', () => {
       ).toEqual({id: ['1', '2', '3']});
     });
 
-    it('should extract query property if no itemIds', function () {
+    it('should extract query property if no itemIds', () => {
       const invalidArgs: any = {
         foo: 'bar',
       };
@@ -22,7 +22,7 @@ describe('group', () => {
       });
     });
 
-    it('should convert params w/o itemIds or query to empty object', function () {
+    it('should convert params w/o itemIds or query to empty object', () => {
       const invalidArgs: any = {
         foo: 'bar',
         bar: 'baz', // paramsToQueryArgs ignores these
@@ -31,7 +31,7 @@ describe('group', () => {
       expect(paramsToQueryArgs(invalidArgs)).toEqual({});
     });
 
-    it('should keep environment when query is provided', function () {
+    it('should keep environment when query is provided', () => {
       expect(
         paramsToQueryArgs({
           query: 'is:unresolved',
@@ -40,7 +40,7 @@ describe('group', () => {
       ).toEqual({query: 'is:unresolved', environment: 'production'});
     });
 
-    it('should exclude environment when it is null/undefined', function () {
+    it('should exclude environment when it is null/undefined', () => {
       expect(
         paramsToQueryArgs({
           query: 'is:unresolved',
@@ -49,7 +49,7 @@ describe('group', () => {
       ).toEqual({query: 'is:unresolved'});
     });
 
-    it('should handle non-empty projects', function () {
+    it('should handle non-empty projects', () => {
       expect(
         paramsToQueryArgs({
           itemIds: ['1', '2', '3'],
@@ -73,12 +73,12 @@ describe('group', () => {
     });
   });
 
-  describe('bulkUpdate()', function () {
-    beforeEach(function () {
+  describe('bulkUpdate()', () => {
+    beforeEach(() => {
       jest.spyOn(GroupStore, 'onUpdate'); // stub GroupStore.onUpdate call from update
     });
 
-    it('should use itemIds as query if provided', function () {
+    it('should use itemIds as query if provided', () => {
       const request = MockApiClient.addMockResponse({
         url: '/projects/1337/1337/issues/',
         method: 'PUT',
@@ -103,7 +103,7 @@ describe('group', () => {
       );
     });
 
-    it('should use query as query if itemIds are absent', function () {
+    it('should use query as query if itemIds are absent', () => {
       const request = MockApiClient.addMockResponse({
         url: '/projects/1337/1337/issues/',
         method: 'PUT',
@@ -128,7 +128,7 @@ describe('group', () => {
       );
     });
 
-    it('should apply project option', function () {
+    it('should apply project option', () => {
       const request = MockApiClient.addMockResponse({
         url: '/organizations/1337/issues/',
         method: 'PUT',
@@ -153,14 +153,14 @@ describe('group', () => {
     });
   });
 
-  describe('mergeGroups()', function () {
+  describe('mergeGroups()', () => {
     // TODO: this is totally copypasta from the test above. We need to refactor
     //       these API methods/tests.
-    beforeEach(function () {
+    beforeEach(() => {
       jest.spyOn(GroupStore, 'onMerge'); // stub GroupStore.onMerge call from mergeGroups
     });
 
-    it('should use itemIds as query if provided', function () {
+    it('should use itemIds as query if provided', () => {
       const request = MockApiClient.addMockResponse({
         url: '/projects/1337/1337/issues/',
         method: 'PUT',
@@ -184,7 +184,7 @@ describe('group', () => {
       );
     });
 
-    it('should use query as query if itemIds are absent', function () {
+    it('should use query as query if itemIds are absent', () => {
       const request = MockApiClient.addMockResponse({
         url: '/projects/1337/1337/issues/',
         method: 'PUT',

static/app/actionCreators/navigation.spec.tsx

@@ -99,7 +99,7 @@ describe('navigation ActionCreator', () => {
     expect(openModal).toHaveBeenCalled();
   });
 
-  it('normalizes URLs for customer domains', function () {
+  it('normalizes URLs for customer domains', () => {
     ConfigStore.set('customerDomain', {
       subdomain: 'albertos-apples',
       organizationUrl: 'https://albertos-apples.sentry.io',
@@ -115,7 +115,7 @@ describe('navigation ActionCreator', () => {
     expect(router.push).toHaveBeenCalledWith('/settings/projects/project-slug/alerts/');
   });
 
-  it('preserves query parameters in path object', function () {
+  it('preserves query parameters in path object', () => {
     router.location.query.project = '2';
     navigateTo(
       {

static/app/actionCreators/organization.spec.tsx

@@ -8,28 +8,28 @@ import OrganizationStore from 'sentry/stores/organizationStore';
 import ProjectsStore from 'sentry/stores/projectsStore';
 import TeamStore from 'sentry/stores/teamStore';
 
-describe('OrganizationActionCreator', function () {
+describe('OrganizationActionCreator', () => {
   const org = OrganizationFixture();
 
   const teams = [TeamFixture()];
   const projects = [ProjectFixture()];
 
   const api = new MockApiClient();
 
-  beforeEach(function () {
+  beforeEach(() => {
     jest.spyOn(TeamStore, 'loadInitialData');
     jest.spyOn(ProjectsStore, 'loadInitialData');
     jest.spyOn(OrganizationStore, 'onUpdate');
     jest.spyOn(OrganizationStore, 'onFetchOrgError');
     jest.spyOn(OrganizationsActionCreator, 'setActiveOrganization');
   });
 
-  afterEach(function () {
+  afterEach(() => {
     jest.restoreAllMocks();
     MockApiClient.clearMockResponses();
   });
 
-  it('fetches organization details', async function () {
+  it('fetches organization details', async () => {
     const getOrgMock = MockApiClient.addMockResponse({
       url: `/organizations/${org.slug}/`,
       body: org,
@@ -65,7 +65,7 @@ describe('OrganizationActionCreator', function () {
     expect(ProjectsStore.loadInitialData).toHaveBeenCalledWith(projects);
   });
 
-  it('errors out correctly', async function () {
+  it('errors out correctly', async () => {
     const getOrgMock = MockApiClient.addMockResponse({
       url: `/organizations/${org.slug}/`,
       statusCode: 400,

static/app/actionCreators/organizations.spec.tsx

@@ -4,16 +4,16 @@ import {fetchOrganizations} from 'sentry/actionCreators/organizations';
 import ConfigStore from 'sentry/stores/configStore';
 import {testableWindowLocation} from 'sentry/utils/testableWindowLocation';
 
-describe('fetchOrganizations', function () {
+describe('fetchOrganizations', () => {
   const api = new MockApiClient();
   const usorg = OrganizationFixture({slug: 'us-org'});
   const deorg = OrganizationFixture({slug: 'de-org'});
 
-  beforeEach(function () {
+  beforeEach(() => {
     MockApiClient.clearMockResponses();
   });
 
-  it('fetches from multiple regions', async function () {
+  it('fetches from multiple regions', async () => {
     ConfigStore.set('memberRegions', [
       {name: 'us', url: 'https://us.example.org'},
       {name: 'de', url: 'https://de.example.org'},
@@ -44,7 +44,7 @@ describe('fetchOrganizations', function () {
     expect(deMock).toHaveBeenCalledTimes(1);
   });
 
-  it('ignores 401 errors from a region', async function () {
+  it('ignores 401 errors from a region', async () => {
     ConfigStore.set('memberRegions', [
       {name: 'us', url: 'https://us.example.org'},
       {name: 'de', url: 'https://de.example.org'},