Skip to content

Commit 40fa0cc

Browse files
authored
feat(onboarding): Add logs to ruby/rails onboarding (#96671)
resolves https://linear.app/getsentry/issue/LOGS-260/add-logs-to-ruby-rails-onboarding
1 parent 0787316 commit 40fa0cc

File tree

3 files changed

+27
-1
lines changed

3 files changed

+27
-1
lines changed

static/app/components/onboarding/productSelection.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,11 @@ export const platformProductAvailability = {
232232
ProductSolution.LOGS,
233233
],
234234
'ruby-rack': [ProductSolution.PERFORMANCE_MONITORING, ProductSolution.PROFILING],
235-
'ruby-rails': [ProductSolution.PERFORMANCE_MONITORING, ProductSolution.PROFILING],
235+
'ruby-rails': [
236+
ProductSolution.PERFORMANCE_MONITORING,
237+
ProductSolution.PROFILING,
238+
ProductSolution.LOGS,
239+
],
236240
} as Record<PlatformKey, ProductSolution[]>;
237241

238242
type ProductProps = {

static/app/gettingStartedDocs/ruby/rails.spec.tsx

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,17 @@ describe('rails onboarding docs', function () {
5656
)
5757
).toBeInTheDocument();
5858
});
59+
60+
it('enables logs by setting enable_logs to true', function () {
61+
renderWithOnboardingLayout(docs, {
62+
selectedProducts: [ProductSolution.ERROR_MONITORING, ProductSolution.LOGS],
63+
});
64+
65+
expect(
66+
screen.getByText(textWithMarkupMatcher(/config.enable_logs = true/))
67+
).toBeInTheDocument();
68+
expect(
69+
screen.getByText(textWithMarkupMatcher(/config.enabled_patches = \[:logger\]/))
70+
).toBeInTheDocument();
71+
});
5972
});

static/app/gettingStartedDocs/ruby/rails.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,15 @@ Sentry.init do |config|
3434
# Add data like request headers and IP for users,
3535
# see https://docs.sentry.io/platforms/ruby/data-management/data-collected/ for more info
3636
config.send_default_pii = true${
37+
params.isLogsSelected
38+
? `
39+
40+
# Enable sending logs to Sentry
41+
config.enable_logs = true
42+
# Patch Ruby logger to forward logs
43+
config.enabled_patches = [:logger]`
44+
: ''
45+
}${
3746
params.isPerformanceSelected
3847
? `
3948

0 commit comments

Comments
 (0)