chore(llm-detector): Add GenAI Consent Check (#104060)

adds the gen ai consent + hide ai features check to the llm issue
detection - since we are still using an allow list, this won't have any
immediate impact but will be a necessary check once we start expanding
the scope of projects allowed

fixes
https://linear.app/getsentry/issue/ID-1100/add-ai-consent-to-detection

Author: roggenkemper

src/sentry/tasks/llm_issue_detection.py

@@ -9,7 +9,7 @@
 from django.conf import settings
 from pydantic import BaseModel
 
-from sentry import options
+from sentry import features, options
 from sentry.issues.grouptype import LLMDetectedExperimentalGroupType
 from sentry.issues.issue_occurrence import IssueEvidence, IssueOccurrence
 from sentry.issues.producer import PayloadType, produce_occurrence_to_kafka
@@ -180,7 +180,13 @@ def detect_llm_issues_for_project(project_id: int) -> None:
     Process a single project for LLM issue detection.
     """
     project = Project.objects.get_from_cache(id=project_id)
-    organization_id = project.organization_id
+    organization = project.organization
+
+    has_access = features.has("organizations:gen-ai-features", organization) and not bool(
+        organization.get_option("sentry:hide_ai_features")
+    )
+    if not has_access:
+        return
 
     transactions = get_transactions_for_project(
         project_id, limit=50, start_time_delta={"minutes": 30}
@@ -220,7 +226,7 @@ def detect_llm_issues_for_project(project_id: int) -> None:
 
             seer_request = {
                 "telemetry": [{**trace.dict(), "kind": "trace"}],
-                "organization_id": organization_id,
+                "organization_id": organization.id,
                 "project_id": project_id,
             }
             response = make_signed_seer_api_request(

tests/sentry/tasks/test_llm_issue_detection.py

@@ -8,6 +8,7 @@
     run_llm_issue_detection,
 )
 from sentry.testutils.cases import TestCase
+from sentry.testutils.helpers.features import with_feature
 from sentry.utils import json
 
 
@@ -28,25 +29,35 @@ def test_run_detection_dispatches_sub_tasks(self, mock_delay):
         assert mock_delay.called
         assert mock_delay.call_args[0][0] == project.id
 
+    @with_feature("organizations:gen-ai-features")
     @patch("sentry.tasks.llm_issue_detection.get_transactions_for_project")
     def test_detect_llm_issues_no_transactions(self, mock_get_transactions):
+        """Test that the task returns early when there are no transactions."""
         mock_get_transactions.return_value = []
 
         detect_llm_issues_for_project(self.project.id)
 
+        mock_get_transactions.assert_called_once_with(
+            self.project.id, limit=50, start_time_delta={"minutes": 30}
+        )
+
+    @with_feature("organizations:gen-ai-features")
     @patch("sentry.tasks.llm_issue_detection.get_trace_for_transaction")
     @patch("sentry.tasks.llm_issue_detection.get_transactions_for_project")
-    @patch("sentry.tasks.llm_issue_detection.random.sample")
-    def test_detect_llm_issues_no_traces(self, mock_sample, mock_get_transactions, mock_get_trace):
+    @patch("sentry.tasks.llm_issue_detection.random.shuffle")
+    def test_detect_llm_issues_no_traces(self, mock_shuffle, mock_get_transactions, mock_get_trace):
+        """Test that the task continues gracefully when traces can't be fetched."""
         mock_transaction = Mock()
         mock_transaction.name = "test_tx"
         mock_transaction.project_id = self.project.id
         mock_get_transactions.return_value = [mock_transaction]
-        mock_sample.side_effect = lambda x, n: x
+        mock_shuffle.return_value = None  # shuffle modifies in place
         mock_get_trace.return_value = None
 
         detect_llm_issues_for_project(self.project.id)
 
+        mock_get_trace.assert_called_once_with(mock_transaction.name, mock_transaction.project_id)
+
     @patch("sentry.tasks.llm_issue_detection.produce_occurrence_to_kafka")
     def test_create_issue_occurrence_from_detection(self, mock_produce_occurrence):
         detected_issue = DetectedIssue(
@@ -140,6 +151,7 @@ def test_create_issue_occurrence_without_missing_telemetry(self, mock_produce_oc
         evidence_names = {e.name for e in occurrence.evidence_display}
         assert evidence_names == {"Explanation", "Impact", "Evidence"}
 
+    @with_feature("organizations:gen-ai-features")
     @patch("sentry.tasks.llm_issue_detection.produce_occurrence_to_kafka")
     @patch("sentry.tasks.llm_issue_detection.make_signed_seer_api_request")
     @patch("sentry.tasks.llm_issue_detection.get_trace_for_transaction")