fix(releases): Use correct type_id for feedback types (#87584)

Author: cmanallen

src/sentry/issues/endpoints/organization_issue_metrics.py

@@ -17,7 +17,7 @@
 from sentry.api.bases.organization import OrganizationEndpoint
 from sentry.api.helpers.environments import get_environments
 from sentry.api.utils import get_date_range_from_params
-from sentry.issues.grouptype import GroupCategory
+from sentry.issues.grouptype import FeedbackGroup
 from sentry.models.group import Group, GroupStatus
 from sentry.models.organization import Organization
 from sentry.models.project import Project
@@ -35,9 +35,9 @@ def get(self, request: Request, organization: Organization) -> Response:
         start, end = get_date_range_from_params(request.GET)
         issue_category = request.GET.get("category", "error")
         type_filter = (
-            ~Q(type=GroupCategory.FEEDBACK)
+            ~Q(type=FeedbackGroup.type_id)
             if issue_category == "error"
-            else Q(type=GroupCategory.FEEDBACK)
+            else Q(type=FeedbackGroup.type_id)
         )
 
         try:

tests/sentry/issues/endpoints/test_organization_issue_metrics.py

@@ -2,6 +2,7 @@
 
 from django.urls import reverse
 
+from sentry.issues.grouptype import FeedbackGroup
 from sentry.testutils.cases import APITestCase
 
 
@@ -27,14 +28,20 @@ def test_get_errors(self):
         self.create_group(project=project1, status=1, first_seen=prev, first_release=one, type=2)
         self.create_group(project=project2, status=1, first_seen=curr, first_release=two, type=3)
         self.create_group(project=project2, status=2, first_seen=curr, first_release=two, type=4)
-        self.create_group(project=project2, status=2, first_seen=curr, first_release=two, type=6)
+        self.create_group(
+            project=project2,
+            status=2,
+            first_seen=curr,
+            first_release=two,
+            type=FeedbackGroup.type_id,
+        )
 
         # Time based issues.
         self.create_group(project=project1, status=0, first_seen=curr, type=1)
         self.create_group(project=project1, status=1, first_seen=curr, resolved_at=curr, type=2)
         self.create_group(project=project2, status=1, first_seen=prev, resolved_at=prev, type=3)
         self.create_group(project=project2, status=2, first_seen=prev, type=4)
-        self.create_group(project=project2, status=2, first_seen=prev, type=6)
+        self.create_group(project=project2, status=2, first_seen=prev, type=FeedbackGroup.type_id)
 
         response = self.client.get(
             self.url + f"?start={prev.isoformat()[:-6]}&end={curr.isoformat()[:-6]}&category=error"
@@ -146,13 +153,13 @@ def test_get_feedback(self):
         self.create_group(project=project1, status=0, first_seen=curr, type=1)
         self.create_group(project=project1, status=1, first_seen=curr, type=2)
         self.create_group(project=project2, status=1, first_seen=curr, type=3)
-        self.create_group(project=project2, status=2, first_seen=prev, type=6)
-        self.create_group(project=project2, status=2, first_seen=curr, type=6)
+        self.create_group(project=project2, status=2, first_seen=prev, type=FeedbackGroup.type_id)
+        self.create_group(project=project2, status=2, first_seen=curr, type=FeedbackGroup.type_id)
         # Resolved cohort
         self.create_group(project=project1, status=0, resolved_at=curr, type=2)
         self.create_group(project=project1, status=1, resolved_at=curr, type=3)
-        self.create_group(project=project2, status=1, resolved_at=prev, type=6)
-        self.create_group(project=project2, status=1, resolved_at=curr, type=6)
+        self.create_group(project=project2, status=1, resolved_at=prev, type=FeedbackGroup.type_id)
+        self.create_group(project=project2, status=1, resolved_at=curr, type=FeedbackGroup.type_id)
         self.create_group(project=project2, status=2, resolved_at=curr, type=5)
 
         response = self.client.get(