Skip to content

Commit 50c0abb

Browse files
ref(ui): Simplify settings Breadcrumbs css (#71083)
1 parent a3c20cc commit 50c0abb

File tree

3 files changed

+8
-21
lines changed

3 files changed

+8
-21
lines changed

static/app/views/settings/components/settingsBreadcrumb/crumb.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import {space} from 'sentry/styles/space';
44

55
const Crumb = styled('div')`
66
display: flex;
7+
gap: ${space(0.75)};
78
align-items: center;
89
position: relative;
910
color: ${p => p.theme.subText};
10-
padding-right: ${space(1)};
1111
cursor: pointer;
1212
white-space: nowrap;
1313
Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import styled from '@emotion/styled';
2-
31
import {IconChevron} from 'sentry/icons';
42

53
type Props = {
@@ -9,21 +7,8 @@ type Props = {
97

108
function Divider({isHover, isLast}: Props) {
119
return isLast ? null : (
12-
<StyledDivider>
13-
<StyledIconChevron direction={isHover ? 'down' : 'right'} size="sm" />
14-
</StyledDivider>
10+
<IconChevron color="gray200" direction={isHover ? 'down' : 'right'} size="xs" />
1511
);
1612
}
1713

18-
const StyledIconChevron = styled(IconChevron)`
19-
display: block;
20-
`;
21-
22-
const StyledDivider = styled('span')`
23-
display: inline-block;
24-
margin-left: 6px;
25-
color: ${p => p.theme.gray200};
26-
position: relative;
27-
`;
28-
2914
export default Divider;

static/app/views/settings/components/settingsBreadcrumb/index.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import styled from '@emotion/styled';
22

33
import Link from 'sentry/components/links/link';
44
import {t} from 'sentry/locale';
5+
import {space} from 'sentry/styles/space';
56
import getRouteStringFromRoutes from 'sentry/utils/getRouteStringFromRoutes';
67
import recreateRoute from 'sentry/utils/recreateRoute';
78

@@ -67,8 +68,6 @@ function SettingsBreadcrumb({className, routes, params}: Props) {
6768
);
6869
}
6970

70-
export default SettingsBreadcrumb;
71-
7271
const CrumbLink = styled(Link)`
7372
display: block;
7473
@@ -78,9 +77,12 @@ const CrumbLink = styled(Link)`
7877
}
7978
`;
8079

81-
export {CrumbLink};
82-
8380
const Breadcrumbs = styled('nav')`
8481
display: flex;
82+
gap: ${space(0.75)};
8583
align-items: center;
8684
`;
85+
86+
export {CrumbLink};
87+
88+
export default SettingsBreadcrumb;

0 commit comments

Comments
 (0)