fix(aci): Use notification_uuid from WorkflowFireHistory when sending notifications (#105471)

When investigating links sent via notification, we usually have access
to the notification_uuid url param which is unique per notification.
To make this useful, we thread through the notification_uuid from
WorkflowFireHistory, which was previously unused, to make it easy to
associate with a history entry and thus a workflow/group/etc.

Author: kcons

src/sentry/integrations/discord/handlers/discord_handler.py

@@ -1,3 +1,5 @@
+from typing import override
+
 from sentry.integrations.types import IntegrationProviderSlug
 from sentry.notifications.models.notificationaction import ActionTarget
 from sentry.notifications.notification_action.action_handler_registry.base import (
@@ -50,5 +52,6 @@ def get_config_transformer() -> ConfigTransformer | None:
         return TargetTypeConfigTransformer.from_config_schema(DiscordActionHandler.config_schema)
 
     @staticmethod
+    @override
     def execute(invocation: ActionInvocation) -> None:
         execute_via_group_type_registry(invocation)

src/sentry/integrations/msteams/handlers/msteams_handler.py

@@ -1,3 +1,5 @@
+from typing import override
+
 from sentry.integrations.types import IntegrationProviderSlug
 from sentry.notifications.notification_action.action_handler_registry.base import (
     IntegrationActionHandler,
@@ -32,5 +34,6 @@ def get_config_transformer() -> ConfigTransformer | None:
         return TargetTypeConfigTransformer.from_config_schema(MSTeamsActionHandler.config_schema)
 
     @staticmethod
+    @override
     def execute(invocation: ActionInvocation) -> None:
         execute_via_group_type_registry(invocation)

src/sentry/integrations/opsgenie/handlers/opsgenie_handler.py

@@ -1,3 +1,5 @@
+from typing import override
+
 from sentry.integrations.opsgenie.utils import OPSGENIE_CUSTOM_PRIORITIES
 from sentry.integrations.types import IntegrationProviderSlug
 from sentry.notifications.notification_action.action_handler_registry.base import (
@@ -37,5 +39,6 @@ def get_config_transformer() -> ConfigTransformer | None:
         return TargetTypeConfigTransformer.from_config_schema(OpsgenieActionHandler.config_schema)
 
     @staticmethod
+    @override
     def execute(invocation: ActionInvocation) -> None:
         execute_via_group_type_registry(invocation)

src/sentry/integrations/pagerduty/handlers/pagerduty_handler.py

@@ -1,3 +1,5 @@
+from typing import override
+
 from sentry.integrations.pagerduty.client import PagerdutySeverity
 from sentry.integrations.types import IntegrationProviderSlug
 from sentry.notifications.notification_action.action_handler_registry.base import (
@@ -37,5 +39,6 @@ def get_config_transformer() -> ConfigTransformer | None:
         return TargetTypeConfigTransformer.from_config_schema(PagerdutyActionHandler.config_schema)
 
     @staticmethod
+    @override
     def execute(invocation: ActionInvocation) -> None:
         execute_via_group_type_registry(invocation)

src/sentry/integrations/slack/handlers/slack_action_handler.py

@@ -1,3 +1,5 @@
+from typing import override
+
 from sentry.integrations.types import IntegrationProviderSlug
 from sentry.notifications.notification_action.action_handler_registry.base import (
     IntegrationActionHandler,
@@ -36,6 +38,7 @@ def get_config_transformer() -> ConfigTransformer | None:
         return TargetTypeConfigTransformer.from_config_schema(SlackActionHandler.config_schema)
 
     @staticmethod
+    @override
     def execute(invocation: ActionInvocation) -> None:
         from sentry.notifications.notification_action.utils import execute_via_group_type_registry
 

src/sentry/integrations/slack/utils/notifications.py

@@ -32,6 +32,7 @@
     get_default_metric_alert_repository,
     get_default_notification_action_repository,
 )
+from sentry.integrations.repository.base import BaseNewNotificationMessage
 from sentry.integrations.repository.metric_alert import (
     MetricAlertNotificationMessage,
     MetricAlertNotificationMessageRepository,
@@ -234,21 +235,17 @@ def _build_notification_payload(
     return attachments, text
 
 
-def _send_notification(
+def _send_notification[Msg: BaseNewNotificationMessage, Repo](
     integration: RpcIntegration,
     metric_issue_context: MetricIssueContext,
     attachments: str,
     text: str,
     channel: str,
     thread_ts: str | None,
     reply_broadcast: bool,
-    notification_message_object: (
-        NewMetricAlertNotificationMessage | NewNotificationActionNotificationMessage
-    ),
-    save_notification_method: Callable,
-    repository: (
-        MetricAlertNotificationMessageRepository | NotificationActionNotificationMessageRepository
-    ),
+    notification_message_object: Msg,
+    save_notification_method: Callable[[Msg, Repo], None],
+    repository: Repo,
 ) -> bool:
     with MessagingInteractionEvent(
         interaction_type=MessagingInteractionType.SEND_INCIDENT_ALERT_NOTIFICATION,

src/sentry/notifications/notification_action/action_handler_registry/base.py

@@ -1,5 +1,6 @@
 import logging
 from abc import ABC
+from typing import override
 
 from sentry.integrations.types import IntegrationProviderSlug
 from sentry.notifications.models.notificationaction import ActionTarget
@@ -59,5 +60,6 @@ def get_config_transformer() -> ConfigTransformer | None:
         return TargetTypeConfigTransformer.from_config_schema(TicketingActionHandler.config_schema)
 
     @staticmethod
+    @override
     def execute(invocation: ActionInvocation) -> None:
         execute_via_issue_alert_handler(invocation)

src/sentry/notifications/notification_action/action_handler_registry/email_handler.py

@@ -1,3 +1,5 @@
+from typing import override
+
 from sentry.notifications.models.notificationaction import ActionTarget
 from sentry.notifications.notification_action.utils import execute_via_group_type_registry
 from sentry.notifications.types import FallthroughChoiceType
@@ -62,5 +64,6 @@ def get_config_transformer(cls) -> ConfigTransformer | None:
         return cls._config_transformer
 
     @staticmethod
+    @override
     def execute(invocation: ActionInvocation) -> None:
         execute_via_group_type_registry(invocation)

src/sentry/notifications/notification_action/action_handler_registry/plugin_handler.py

@@ -1,3 +1,5 @@
+from typing import override
+
 from sentry.notifications.notification_action.utils import execute_via_group_type_registry
 from sentry.workflow_engine.models import Action
 from sentry.workflow_engine.registry import action_handler_registry
@@ -32,5 +34,6 @@ def get_config_transformer() -> ConfigTransformer | None:
         return None
 
     @staticmethod
+    @override
     def execute(invocation: ActionInvocation) -> None:
         execute_via_group_type_registry(invocation)

src/sentry/notifications/notification_action/action_handler_registry/sentry_app_handler.py

@@ -1,3 +1,5 @@
+from typing import override
+
 from sentry.notifications.models.notificationaction import ActionTarget
 from sentry.notifications.notification_action.utils import execute_via_group_type_registry
 from sentry.workflow_engine.models import Action
@@ -46,5 +48,6 @@ def get_config_transformer() -> ConfigTransformer | None:
         return TargetTypeConfigTransformer.from_config_schema(SentryAppActionHandler.config_schema)
 
     @staticmethod
+    @override
     def execute(invocation: ActionInvocation) -> None:
         execute_via_group_type_registry(invocation)