ref(nav-v2): removes nav v2 flag (#95955)

Nav V2 is GAed and available for everyone (see
[automator](https://github.com/getsentry/sentry-options-automator/blob/507cffc82679fc5aee370808a4b084dc6a416d27/options/default/flagpole.yml#L3538)),
so we don't need the flag. Follow up to
#95951.

Author: cvxluo

static/app/components/performanceOnboarding/sidebar.spec.tsx

@@ -61,6 +61,11 @@ describe('Sidebar > Performance Onboarding Checklist', function () {
       body: [broadcast],
     });
 
+    MockApiClient.addMockResponse({
+      url: `/organizations/${organization.slug}/prompts-activity/`,
+      body: {data: null},
+    });
+
     MockApiClient.addMockResponse({
       url: `/organizations/${organization.slug}/onboarding-tasks/`,
       method: 'GET',

static/app/components/sidebar/help.tsx

@@ -98,21 +98,19 @@ function SidebarHelp({orientation, collapsed, hidePanel, organization}: Props) {
                   {t('Give Feedback')}
                 </SidebarMenuItem>
               ) : null}
-              {organization?.features?.includes('navigation-sidebar-v2') && (
-                <SidebarMenuItem
-                  onClick={() => {
-                    mutateUserOptions({prefersStackedNavigation: true});
-                    trackAnalytics(
-                      'navigation.help_menu_opt_in_stacked_navigation_clicked',
-                      {
-                        organization,
-                      }
-                    );
-                  }}
-                >
-                  {t('Try New Navigation')} <FeatureBadge type="new" />
-                </SidebarMenuItem>
-              )}
+              <SidebarMenuItem
+                onClick={() => {
+                  mutateUserOptions({prefersStackedNavigation: true});
+                  trackAnalytics(
+                    'navigation.help_menu_opt_in_stacked_navigation_clicked',
+                    {
+                      organization,
+                    }
+                  );
+                }}
+              >
+                {t('Try New Navigation')} <FeatureBadge type="new" />
+              </SidebarMenuItem>
               {organization?.features?.includes('chonk-ui') ? (
                 user.options.prefersChonkUI ? (
                   <SidebarMenuItem

static/app/components/sidebar/index.spec.tsx

@@ -5,7 +5,14 @@ import {OrganizationFixture} from 'sentry-fixture/organization';
 import {ServiceIncidentFixture} from 'sentry-fixture/serviceIncident';
 import {UserFixture} from 'sentry-fixture/user';
 
-import {act, render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';
+import {
+  act,
+  render,
+  screen,
+  userEvent,
+  waitFor,
+  within,
+} from 'sentry-test/reactTestingLibrary';
 
 import {logout} from 'sentry/actionCreators/account';
 import {OnboardingContextProvider} from 'sentry/components/onboarding/onboardingContext';
@@ -91,6 +98,10 @@ describe('Sidebar', function () {
       method: 'GET',
       body: {onboardingTasks: []},
     });
+    MockApiClient.addMockResponse({
+      url: `/organizations/${organization.slug}/prompts-activity/`,
+      body: {data: null},
+    });
   });
 
   afterEach(function () {
@@ -412,23 +423,13 @@ describe('Sidebar', function () {
     });
 
     it('should render the sidebar banner with no dismissed prompts and the feature flag enabled', async () => {
-      MockApiClient.addMockResponse({
-        url: `/organizations/${organization.slug}/prompts-activity/`,
-        body: {data: null},
-      });
-
-      renderSidebarWithFeatures(['navigation-sidebar-v2']);
+      renderSidebar({organization});
 
       expect(await screen.findByText(/New Navigation/)).toBeInTheDocument();
     });
 
     it('will not render sidebar banner when collapsed', async () => {
-      MockApiClient.addMockResponse({
-        url: `/organizations/${organization.slug}/prompts-activity/`,
-        body: {data: null},
-      });
-
-      renderSidebarWithFeatures(['navigation-sidebar-v2']);
+      renderSidebar({organization});
 
       await userEvent.click(screen.getByTestId('sidebar-collapse'));
 
@@ -438,18 +439,13 @@ describe('Sidebar', function () {
     });
 
     it('should show dot on help menu after dismissing sidebar banner', async () => {
-      MockApiClient.addMockResponse({
-        url: `/organizations/${organization.slug}/prompts-activity/`,
-        body: {data: null},
-      });
-
       const dismissMock = MockApiClient.addMockResponse({
         url: `/organizations/${organization.slug}/prompts-activity/`,
         method: 'PUT',
         body: {},
       });
 
-      renderSidebarWithFeatures(['navigation-sidebar-v2']);
+      renderSidebar({organization});
 
       await userEvent.click(await screen.findByRole('button', {name: /Dismiss/}));
 
@@ -480,11 +476,6 @@ describe('Sidebar', function () {
         options: {...user.options, prefersChonkUI: true},
       });
 
-      MockApiClient.addMockResponse({
-        url: `/organizations/${organization.slug}/prompts-activity/`,
-        body: {data: null},
-      });
-
       renderSidebarWithFeatures(['chonk-ui']);
       expect(screen.queryByText(/Sentry has a new look/)).not.toBeInTheDocument();
     });
@@ -528,11 +519,6 @@ describe('Sidebar', function () {
         options: {...user.options, prefersChonkUI: false},
       });
 
-      MockApiClient.addMockResponse({
-        url: `/organizations/${organization.slug}/prompts-activity/`,
-        body: {data: null},
-      });
-
       const dismiss = MockApiClient.addMockResponse({
         url: `/organizations/${organization.slug}/prompts-activity/`,
         method: 'PUT',
@@ -591,11 +577,6 @@ describe('Sidebar', function () {
         options: {...user.options, prefersChonkUI: false},
       });
 
-      MockApiClient.addMockResponse({
-        url: `/organizations/${organization.slug}/prompts-activity/`,
-        body: {data: null},
-      });
-
       const dismiss = MockApiClient.addMockResponse({
         url: `/organizations/${organization.slug}/prompts-activity/`,
         method: 'PUT',
@@ -610,8 +591,15 @@ describe('Sidebar', function () {
 
       // The dot is not visible initially - banner takes precedence
       expect(screen.queryByTestId('help-menu-dot')).not.toBeInTheDocument();
-      expect(await screen.findByText(/Sentry has a new look/)).toBeInTheDocument();
-      await userEvent.click(screen.getByRole('button', {name: /Dismiss/}));
+      const chonkBanner = await screen.findByText(/Sentry has a new look/);
+      expect(chonkBanner).toBeInTheDocument();
+
+      // Find the dismiss button within the chonk UI banner
+      await userEvent.click(
+        within(screen.getByRole('complementary')).getByRole('button', {
+          name: /Dismiss/,
+        })
+      );
 
       expect(optionsRequest).not.toHaveBeenCalled();
       expect(dismiss).toHaveBeenCalledWith(

static/app/utils/theme/ChonkOptInBanner.tsx

@@ -1,3 +1,4 @@
+import {useId} from 'react';
 import type {Theme} from '@emotion/react';
 import {ThemeProvider} from '@emotion/react';
 import styled from '@emotion/styled';
@@ -18,17 +19,20 @@ export function ChonkOptInBanner(props: {collapsed: boolean | 'never'}) {
   const chonkPrompt = useChonkPrompt();
   const config = useLegacyStore(ConfigStore);
   const {mutate: mutateUserOptions} = useMutateUserOptions();
+  const id = useId();
 
   if (props.collapsed === true || !chonkPrompt.showbannerPrompt) {
     return null;
   }
 
   return (
     <TranslucentBackgroundPanel
+      role="complementary"
+      aria-labelledby={id}
       isDarkMode={config.theme === 'dark'}
       position={props.collapsed === 'never' ? 'absolute' : 'relative'}
     >
-      <Title>{t('Sentry has a new look')}</Title>
+      <Title id={id}>{t('Sentry has a new look')}</Title>
       <Description>
         {t(`We've updated Sentry with a fresh new look, try it out by opting in below.`)}
       </Description>

static/app/views/nav/useNavPrompts.tsx

@@ -8,15 +8,12 @@ export function useNavPrompts({
   collapsed: boolean;
   organization: Organization | null;
 }) {
-  const hasNavigationV2Banner = organization?.features.includes('navigation-sidebar-v2');
-
   const {
     isPromptDismissed: isSidebarPromptDismissed,
     dismissPrompt: dismissSidebarPrompt,
   } = usePrompt({
     feature: 'stacked_navigation_banner',
     organization,
-    options: {enabled: hasNavigationV2Banner},
   });
 
   const {
@@ -25,17 +22,13 @@ export function useNavPrompts({
   } = usePrompt({
     feature: 'stacked_navigation_help_menu',
     organization,
-    options: {enabled: hasNavigationV2Banner},
   });
 
   const shouldShowHelpMenuDot =
-    hasNavigationV2Banner &&
-    isDropdownPromptDismissed === false &&
-    (collapsed || isSidebarPromptDismissed);
+    isDropdownPromptDismissed === false && (collapsed || isSidebarPromptDismissed);
 
   return {
-    shouldShowSidebarBanner:
-      hasNavigationV2Banner && !collapsed && isSidebarPromptDismissed === false,
+    shouldShowSidebarBanner: !collapsed && isSidebarPromptDismissed === false,
     shouldShowHelpMenuDot,
     onOpenHelpMenu: () => {
       if (shouldShowHelpMenuDot) {