Skip to content

Commit a7e6426

Browse files
authored
fix(prevent): update comment image on prevent onboarding page / org settings link (#97494)
2 small fixes for the onboarding page Updates image to one that's a lot clearer, thanks @Adal3n3! And also fixes the link when you click on organization settings to take you to the right place Closes https://linear.app/getsentry/issue/PREVENT-246/prevent-onboarding-polish-onboarding-page <img width="1667" height="861" alt="Screenshot 2025-08-08 at 10 37 57 AM" src="https://github.com/user-attachments/assets/55833600-dd33-4d2c-9635-925b0f06bd04" /> <img width="1667" height="791" alt="Screenshot 2025-08-08 at 10 37 36 AM" src="https://github.com/user-attachments/assets/7d35c227-5e10-4e13-bf87-4e8be13bd030" /> <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
1 parent 303ebbe commit a7e6426

File tree

4 files changed

+9
-14
lines changed

4 files changed

+9
-14
lines changed

static/app/views/codecov/preventAI/onboarding.spec.tsx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import PreventAIOnboarding from './onboarding';
77

88
jest.mock('sentry-images/features/prevent-hero.svg', () => 'prevent-hero-mock.svg');
99
jest.mock(
10-
'sentry-images/features/prevent-pr-comments.png',
11-
() => 'prevent-pr-comments-mock.png'
10+
'sentry-images/features/prevent-pr-comment.png',
11+
() => 'prevent-pr-comment-mock.png'
1212
);
1313

1414
describe('PreventAIOnboarding', function () {
@@ -59,10 +59,7 @@ describe('PreventAIOnboarding', function () {
5959
render(<PreventAIOnboarding />, {organization});
6060

6161
const orgSettingsLink = screen.getByRole('link', {name: 'organization settings'});
62-
expect(orgSettingsLink).toHaveAttribute(
63-
'href',
64-
'/settings/test-org/security-and-privacy'
65-
);
62+
expect(orgSettingsLink).toHaveAttribute('href', '/settings/test-org');
6663

6764
const githubIntegrationLink = screen.getByRole('link', {
6865
name: 'GitHub integration instructions',
@@ -134,9 +131,9 @@ describe('PreventAIOnboarding', function () {
134131
const heroImage = screen.getByAltText('Prevent AI Hero');
135132
expect(heroImage).toBeInTheDocument();
136133

137-
const prCommentsImage = screen.getByAltText('Prevent PR Comments');
138-
expect(prCommentsImage).toBeInTheDocument();
139-
expect(prCommentsImage).toHaveAttribute('src', 'prevent-pr-comments-mock.png');
134+
const prCommentImage = screen.getByAltText('Prevent PR Comment');
135+
expect(prCommentImage).toBeInTheDocument();
136+
expect(prCommentImage).toHaveAttribute('src', 'prevent-pr-comment-mock.png');
140137
});
141138

142139
it('renders admin notice text', function () {

static/app/views/codecov/preventAI/onboarding.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {useTheme} from '@emotion/react';
22
import styled from '@emotion/styled';
33

44
import preventHero from 'sentry-images/features/prevent-hero.svg';
5-
import preventPrComments from 'sentry-images/features/prevent-pr-comments.png';
5+
import preventPrComment from 'sentry-images/features/prevent-pr-comment.png';
66

77
import {Container, Flex} from 'sentry/components/core/layout';
88
import {ExternalLink} from 'sentry/components/core/link';
@@ -97,9 +97,7 @@ export default function PreventAIOnboarding() {
9797
'Make sure AI features are enabled in your [organizationSettingsLink:organization settings].',
9898
{
9999
organizationSettingsLink: (
100-
<ExternalLink
101-
href={`/settings/${organization.slug}/security-and-privacy`}
102-
/>
100+
<ExternalLink href={`/settings/${organization.slug}`} />
103101
),
104102
}
105103
)}
@@ -196,7 +194,7 @@ export default function PreventAIOnboarding() {
196194
</Text>
197195
</Flex>
198196
</Flex>
199-
<StyledImg src={preventPrComments} alt="Prevent PR Comments" />
197+
<StyledImg src={preventPrComment} alt="Prevent PR Comment" />
200198
</Flex>
201199
</Flex>
202200
);
484 KB
Loading
-245 KB
Binary file not shown.

0 commit comments

Comments
 (0)