Skip to content

fix(feedback): Remove deprecated props from feedback index #101180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
+6 −9
Merged

fix(feedback): Remove deprecated props from feedback index #101180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions static/app/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2510,7 +2510,6 @@ function buildRoutes(): RouteObject[] {
component: make(() => import('sentry/views/feedback/index')),
withOrgPath: true,
children: feedbackV2Children,
deprecatedRouteProps: true,
};

const issueTabs: SentryRouteObject[] = [
Expand Down Expand Up @@ -2638,7 +2637,6 @@ function buildRoutes(): RouteObject[] {
path: 'feedback/',
component: make(() => import('sentry/views/feedback/index')),
children: feedbackV2Children,
deprecatedRouteProps: true,
},
{
path: 'alerts/',
Expand Down
13 changes: 6 additions & 7 deletions static/app/views/feedback/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
import {Outlet} from 'react-router-dom';

import AnalyticsArea from 'sentry/components/analyticsArea';
import NoProjectMessage from 'sentry/components/noProjectMessage';
import Redirect from 'sentry/components/redirect';
import type {RouteComponentProps} from 'sentry/types/legacyReactRouter';
import useOrganization from 'sentry/utils/useOrganization';
import {useRedirectNavV2Routes} from 'sentry/views/nav/useRedirectNavV2Routes';

type Props = RouteComponentProps & {
children: React.ReactNode;
};

export default function FeedbackContainer({children}: Props) {
export default function FeedbackContainer() {
const organization = useOrganization();

const redirectPath = useRedirectNavV2Routes({
Expand All @@ -23,7 +20,9 @@ export default function FeedbackContainer({children}: Props) {

return (
<AnalyticsArea name="feedback">
<NoProjectMessage organization={organization}>{children}</NoProjectMessage>
<NoProjectMessage organization={organization}>
<Outlet />
</NoProjectMessage>
</AnalyticsArea>
);
}
Loading