Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/release_health/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"foreground_anr_rate()",
"unhandled_rate(session)",
"unhandled_rate(user)",
"unhealthy_rate(session)",
]

GroupByFieldName = Literal[
Expand Down
2 changes: 2 additions & 0 deletions src/sentry/release_health/metrics_sessions_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ class SimpleForwardingField(Field):
"foreground_anr_rate()": SessionMRI.FOREGROUND_ANR_RATE,
"unhandled_rate(session)": SessionMRI.UNHANDLED_RATE,
"unhandled_rate(user)": SessionMRI.UNHANDLED_USER_RATE,
"unhealthy_rate(session)": SessionMRI.UNHEALTHY_RATE,
}

def __init__(self, name: str, raw_groupby: Sequence[str], status_filter: StatusFilter):
Expand Down Expand Up @@ -387,6 +388,7 @@ def _get_metric_fields(
"foreground_anr_rate()": SimpleForwardingField,
"unhandled_rate(session)": SimpleForwardingField,
"unhandled_rate(user)": SimpleForwardingField,
"unhealthy_rate(session)": SimpleForwardingField,
}
PREFLIGHT_QUERY_COLUMNS = {"release.timestamp"}
VirtualOrderByName = Literal["release.timestamp"]
Expand Down
9 changes: 9 additions & 0 deletions src/sentry/snuba/metrics/fields/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1587,6 +1587,15 @@ def generate_where_statements(
unit="sessions",
post_query_func=lambda init, errored: max(0, init - errored),
),
CompositeEntityDerivedMetric(
metric_mri=SessionMRI.UNHEALTHY_RATE.value,
metrics=[
SessionMRI.ALL.value,
SessionMRI.ERRORED_ALL.value,
],
unit="percentage",
post_query_func=lambda all, errored_all: (max(0, errored_all / all) if all else 0),
),
SingularEntityDerivedMetric(
metric_mri=SessionMRI.HEALTHY_USER.value,
metrics=[
Expand Down
1 change: 1 addition & 0 deletions src/sentry/snuba/metrics/naming_layer/mri.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ class SessionMRI(Enum):
UNHANDLED_RATE = "e:sessions/unhandled_rate@ratio" # unhandled, does not include crashed
CRASH_RATE = "e:sessions/crash_rate@ratio"
CRASH_FREE_RATE = "e:sessions/crash_free_rate@ratio" # includes handled and unhandled
UNHEALTHY_RATE = "e:sessions/unhealthy_rate@ratio"
ALL_USER = "e:sessions/user.all@none"
HEALTHY_USER = "e:sessions/user.healthy@none"
ERRORED_USER = "e:sessions/user.errored@none"
Expand Down
56 changes: 56 additions & 0 deletions tests/snuba/api/endpoints/test_organization_sessions.py
Original file line number Diff line number Diff line change
Expand Up @@ -1823,6 +1823,62 @@ def req(**kwargs):
},
]

@freeze_time(MOCK_DATETIME)
def test_unhealthy_rate(self) -> None:
default_request = {
"project": [-1],
"statsPeriod": "1d",
"interval": "1d",
"field": ["unhealthy_rate(session)"],
}

def req(**kwargs):
return self.do_request(dict(default_request, **kwargs))

# 1 - filter session.status
response = req(
query="session.status:[abnormal,crashed]",
)
assert response.status_code == 400, response.content
assert response.data == {
"detail": "Cannot filter field unhealthy_rate(session) by session.status"
}

# 2 - group by session.status
response = req(
groupBy="session.status",
)
assert response.status_code == 400, response.content
assert response.data == {
"detail": "Cannot group field unhealthy_rate(session) by session.status"
}

# 3 - fetch [email protected] release
response = req(
field=[
"unhealthy_rate(session)",
"sum(session)",
],
groupBy=["release", "environment"],
query="release:[email protected]",
)
assert response.status_code == 200, response.content
group = response.data["groups"][0]
assert group["totals"]["sum(session)"] == 8
assert group["totals"]["unhealthy_rate(session)"] == pytest.approx(0.5)

# 4 - fetch all
response = req(
field=[
"unhealthy_rate(session)",
"sum(session)",
],
)
assert response.status_code == 200, response.content
group = response.data["groups"][0]
assert group["totals"]["sum(session)"] == 11
assert group["totals"]["unhealthy_rate(session)"] == pytest.approx(5 / 11)

@freeze_time(MOCK_DATETIME)
def test_pagination(self) -> None:
def do_request(cursor):
Expand Down
Loading