chore(unmerge): Add more context when logging #101190
Open
+9
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would have helped us when investigating some unmerge customer issue.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Oct 8, 2025
| def unmerge(*posargs: Any, **kwargs: Any) -> None: | ||
| args = UnmergeArgsBase.parse_arguments(*posargs, **kwargs) | ||
| extra = {"source_id": args.source_id, "project_id": args.project_id} | ||
| logger.info("unmerge.start.task", extra=extra) |
There was a problem hiding this comment.
I believe @nora-shap and I would have benefited from having this.
| def unmerge(*posargs: Any, **kwargs: Any) -> None: | ||
| args = UnmergeArgsBase.parse_arguments(*posargs, **kwargs) | ||
| extra = {"source_id": args.source_id, "project_id": args.project_id} | ||
| logger.info("unmerge.start.task", extra=extra) |
There was a problem hiding this comment.
This would have helped me and @nora-shap when we were debugging.
JoshFerge
approved these changes
Oct 8, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101190 +/- ##
===========================================
- Coverage 81.09% 81.03% -0.06%
===========================================
Files 8669 8671 +2
Lines 384603 386293 +1690
Branches 24275 24275
===========================================
+ Hits 311888 313042 +1154
- Misses 72368 72904 +536
Partials 347 347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have helped us when investigating some unmerge customer issue.