Skip to content

Conversation

narsaynorath
Copy link
Member

@narsaynorath narsaynorath commented Oct 8, 2025

The metric types we support are currently counter, distribution, and gauge. When the metric is selected, the applicable options are presented for aggregates.

Updates the context to serialize the aggregateFields to the URL and adds a new component that renders a static list of options for the user to select. When a selection is made, we update the yAxis for that visualize context.

Notes:

  • I haven't implemented default behaviour if the selected aggregate isn't compatible (i.e. going from a distribution looking at the percentile -> a counter, since counters don't have percentile). I will follow up at a later time
  • In a future PR, I will update the metric context we use to store the name to also store the type so it can handle metrics with conflicting names but different types. At the moment it simply uses a .find to get the type

Demo:

Screen.Recording.2025-10-08.at.3.41.57.PM.mov

The metric types we support are currently counter, distribution, and gauge. When
the metric is selected, the applicable options are presented for aggregates.
@narsaynorath narsaynorath requested a review from a team as a code owner October 8, 2025 19:32
Copy link

linear bot commented Oct 8, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 8, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@narsaynorath narsaynorath enabled auto-merge (squash) October 8, 2025 21:27
@narsaynorath narsaynorath merged commit 9007b32 into master Oct 8, 2025
46 checks passed
@narsaynorath narsaynorath deleted the narsaynorath/logs-403-show-applicable-aggregates-in-the-select-field branch October 8, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants