feat(dashboards): add create link button to table edit #101204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const dashboardsPath = | ||
| selectedDashboardId === NEW_DASHBOARD_ID | ||
| ? `/organizations/${organization.slug}/dashboards/new/` | ||
| : `/organizations/${organization.slug}/dashboard/${selectedDashboardId}/`; |
There was a problem hiding this comment.
Bug: Dashboard Creation Path Inconsistent
The "Create New Dashboard" option uses the string value 'new', but the modal's logic checks against the NEW_DASHBOARD_ID constant. This inconsistency means the new dashboard creation path won't be taken, preventing users from creating new dashboards through this modal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some initial work for drill down flows. This adds the create link button when editing a table and a corresponding modal. This stuff doesn't do anything yet as i'm working on some backend changes at the same time. And a lot will change between now and the final, putting this PR up to make it easier to review.