fix(replay): Iterate on the bulk "Delete" replay button when its disabled #101498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled We want to make it more obvious that permissions are needed, and make it accessible for people on mobile devices
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| selectedIds={selectedIds} | ||
| /> | ||
| ) : null} | ||
| </Tooltip> |
Contributor
There was a problem hiding this comment.
Bug: Button and Tooltip Vanish on Null Project
The DeleteReplays button and its tooltip disappear when project is null, even if oneProjectEligible is true and a disabled state with an explanation is intended. This happens because the button is conditionally rendered based on project's existence, which also causes the Tooltip to receive null children.
|
|
||
| {isAllSelected && disabledMessage ? ( | ||
| <FullGridAlert type="error" system> | ||
| {disabledMessage} |
Contributor
There was a problem hiding this comment.
Bug: Permission Banner Missing for Partial Selection
The permission error banner for deleting replays only appears when all replays are selected. When only some replays are selected, the delete button is disabled, but the banner explaining the lack of permission doesn't show up, leaving users without an explanation for the disabled action.
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Member
Author
|
@sentry review |
|
Seer had some issues with your request. Please try again. |
Member
Author
|
@sentry review |
|
Seer had some issues with your request. Please try again. |
srest2021
reviewed
Nov 5, 2025
| selectedIds={selectedIds} | ||
| /> | ||
| <Tooltip disabled={!disabledMessage} title={disabledMessage}> | ||
| {project ? ( |
Member
There was a problem hiding this comment.
Disabled delete button now disappears when banner is "Select a single project from the dropdown to delete replays", but not when banner is "You must have project:write or project:admin access to delete replays" -- is this intentional?
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make it more obvious that permissions are needed, and make the tooltip accessible for people on mobile devices
So i've added a red banner that appears after making a selection to inform the user. This is not a scalable solution, if there were more multi-select action-buttons then it wouldn't make as much sense to throw a banner up there for each button, explaining all the different permissions. What we're trying to do though is make things more discoverable for now (short term!) because people have missed the tooltip and have been confused.
Fixes https://linear.app/getsentry/issue/REPLAY-763