chore(deletions): Move tasks under sentry.deletions #104009
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for consistencies sake.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Nov 25, 2025
| }, | ||
| "delete-pending-groups": { | ||
| "task": "deletions:sentry.tasks.delete_pending_groups", | ||
| "task": "deletions:sentry.deletions.tasks.delete_pending_groups", |
Member
Author
There was a problem hiding this comment.
@markstory will something break if I rename this task?
| "sentry.tasks.beacon", | ||
| "sentry.tasks.codeowners.*", | ||
| "sentry.tasks.commit_context", | ||
| "sentry.tasks.delete_seer_grouping_records", |
Member
Author
There was a problem hiding this comment.
sentry.deletions.* is strongly typed, thus, no need to list this module explicitely.
❌ 12 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Bug: Task name not updated in decorator
The task name in the @instrumented_task decorator for call_seer_delete_project_grouping_records wasn't updated from sentry.tasks.call_seer_delete_project_grouping_records to sentry.deletions.tasks.call_seer_delete_project_grouping_records. This inconsistency means the task is registered under the old namespace instead of the new sentry.deletions namespace, defeating the purpose of this refactoring and potentially causing task routing issues if the old task name is referenced elsewhere in the codebase.
src/sentry/deletions/tasks/delete_seer_grouping_records.py#L88-L89
sentry/src/sentry/deletions/tasks/delete_seer_grouping_records.py
Lines 88 to 89 in 40804a5
Bug: Outdated patch decorator references old module path
Several @patch decorators in test files still reference the old module paths like sentry.tasks.delete_pending_groups.metrics.incr and sentry.tasks.delete_seer_grouping_records.delete_seer_grouping_records_by_hash.apply_async instead of the new sentry.deletions.tasks.* paths. These patches won't work correctly because the modules have been moved, causing the tests to either fail or not properly mock the intended functions.
tests/sentry/deletions/tasks/test_delete_pending_groups.py#L116-L117
sentry/tests/sentry/deletions/tasks/test_delete_pending_groups.py
Lines 116 to 117 in 40804a5
tests/sentry/deletions/tasks/test_delete_seer_grouping_records.py#L30-L31
tests/sentry/deletions/tasks/test_delete_seer_grouping_records.py#L51-L52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want tasks dealing with deletion to start with
sentry.deletionsto have consistency with the rest and find them more easily.