fix(aci): accept str instead of int for extrapolation mode in validator #104015
+124
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
malwilley
reviewed
Nov 25, 2025
| if name == extrapolation_mode: | ||
| extrapolation_mode = ExtrapolationMode(value) | ||
| break | ||
| if type(extrapolation_mode) is not ExtrapolationMode: |
Member
There was a problem hiding this comment.
Can you add a validate_extrapolation_mode() function to this validator that will transform the value into the enum class automatically? That way you won't need to do it here
| if extrapolation_mode is not None: | ||
| extrapolation_mode = ExtrapolationMode(extrapolation_mode) | ||
| extrapolation_mode_options = ExtrapolationMode.as_text_choices() | ||
| for name, value in extrapolation_mode_options: |
Member
There was a problem hiding this comment.
Instead of this, you can add a classmethod from_str(self, name: str) function to ExtrapolationMode. We do that for some other enums. Then you can just do ExtrapolationMode.from_str(extrapolation_mode)
|
|
||
| def _validate_extrapolation_mode(self, extrapolation_mode: str) -> None: | ||
| if extrapolation_mode == ExtrapolationMode.SERVER_WEIGHTED.value: | ||
| if extrapolation_mode is not None and extrapolation_mode not in [ |
Member
There was a problem hiding this comment.
This will also be simpler if you return the enum from the validator
| "Failed to send data to Seer, cannot update detector" | ||
| ) | ||
|
|
||
| numerical_extrapolation_mode = format_extrapolation_mode( |
Member
There was a problem hiding this comment.
If you return an enum, you can instead do:
numerical_extrapolation_mode = data_source.get("extrapolation_mode", snuba_query.extrapolation_mode.value)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
malwilley
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack thread for context: https://sentry.slack.com/archives/C07H2DHMSS0/p1764091469147239
Extrapolation mode would not be accepted as a string in the validator (which is what it gets passed to the backend as) so it was throwing an error on detector updates. Along with this I had to fix some tests and other logic that went into validating the extrapolation mode so we ensure we're comparing correct types.