Skip to content

Conversation

@edwardgou-sentry
Copy link
Contributor

  • Updates prebuilt dashboards to display metadata and preview properly in table and grid views in the All Dashboards page
    • Fix number of widgets display
    • Adds tooltip to owner icon
    • Fix preview grid not displaying
  • Disables access management in the All Dashboards page for prebuilt dashboards
  • Disables delete capability in the the All Dashboards page for prebuilt dashboards
image image

…to display properly. Also disable delete and edit buttons for prebuilt dashboards
@edwardgou-sentry edwardgou-sentry requested a review from a team November 25, 2025 21:47
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner November 25, 2025 21:47
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2025
}}
priority="primary"
disabled={
disabled ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not major, can be done later, but this block is hard to read, maybe we should move dropdownFooterButtons to it's own component, and consolidate some of the disabling logic below.

);

const dashboards = dashboardsWithoutPrebuiltConfigs?.map(dashboard => {
if (dashboard.prebuiltId && dashboard.prebuiltId in PREBUILT_DASHBOARDS) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would memoize this, looks like it's doing a lot, instantiating objects, which can lead to some unnecessary re-renders.

Copy link
Contributor

@Abdkhan14 Abdkhan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, got a few comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants