-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(dashboards): Updates prebuilt dashboard preview and management in the All Dashboards view #104018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(dashboards): Updates prebuilt dashboard preview and management in the All Dashboards view #104018
Conversation
edwardgou-sentry
commented
Nov 25, 2025
- Updates prebuilt dashboards to display metadata and preview properly in table and grid views in the All Dashboards page
- Fix number of widgets display
- Adds tooltip to owner icon
- Fix preview grid not displaying
- Disables access management in the All Dashboards page for prebuilt dashboards
- Disables delete capability in the the All Dashboards page for prebuilt dashboards
…to display properly. Also disable delete and edit buttons for prebuilt dashboards
| }} | ||
| priority="primary" | ||
| disabled={ | ||
| disabled || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not major, can be done later, but this block is hard to read, maybe we should move dropdownFooterButtons to it's own component, and consolidate some of the disabling logic below.
| ); | ||
|
|
||
| const dashboards = dashboardsWithoutPrebuiltConfigs?.map(dashboard => { | ||
| if (dashboard.prebuiltId && dashboard.prebuiltId in PREBUILT_DASHBOARDS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would memoize this, looks like it's doing a lot, instantiating objects, which can lead to some unnecessary re-renders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, got a few comments above