-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore(explore): Remove used explore flag backend #104021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(explore): Remove used explore flag backend #104021
Conversation
This flag has been rolled out so we can remove it now. Depends on #104020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Frontend still checks removed feature flag
The backend flag visibility-explore-aggregate-editor is being removed, but the frontend code in static/app/views/explore/tables/index.tsx at line 110 still checks for this flag. After removal, the flag will no longer be in organization.features, causing the aggregate table editor button to become disabled instead of enabled, effectively disabling a feature that was rolled out.
src/sentry/features/temporary.py#L519-L521
sentry/src/sentry/features/temporary.py
Lines 519 to 521 in 9c47a6a
| manager.add("organizations:view-hierarchies-options-dev", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) | |
| # Enable equations feature on the new explore page | |
| manager.add("organizations:visibility-explore-equations", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True) |
…egate-editor-flag-backend
…egate-editor-flag-backend
…/remove-visibility-explore-aggregate-editor-flag-backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Unrelated feature flag removed without mention in PR
The PR title and description only mention removing visibility-explore-aggregate-editor, but this change also removes the unrelated organizations:ourlogs-high-fidelity flag which controls "UI for log high fidelity queries". This appears to be accidentally included in the commit since it's not mentioned in the PR scope and represents a different feature area (logs high fidelity vs explore aggregate editor).
src/sentry/features/temporary.py#L586-L587
sentry/src/sentry/features/temporary.py
Lines 586 to 587 in 266539d
| # Enable service hooks outbox | |
| manager.add("organizations:service-hooks-outbox", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False) |
This flags has been rolled out so we can remove it now.
Depends on #104020 and #104016