Skip to content

Conversation

@ceorourke
Copy link
Member

Similar to #103694 except the data isn't stored like this in the db so we thankfully don't have to run a migration - this was just incorrect in tests.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
30041 3 30038 241
View the top 3 failed test(s) by shortest run time
tests.sentry.workflow_engine.migration_helpers.test_migrate_rule_action.TestNotificationActionMigrationUtils::test_action_type_in_migration
Stack Traces | 3.25s run time
#x1B[1m#x1B[.../workflow_engine/migration_helpers/test_migrate_rule_action.py#x1B[0m:885: in test_action_type_in_migration
    assert len(actions) == 1
#x1B[1m#x1B[31mE   assert 0 == 1#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = len([])#x1B[0m
tests.sentry.workflow_engine.migration_helpers.test_migrate_rule_action.TestNotificationActionMigrationUtils::test_email_migration
Stack Traces | 3.48s run time
#x1B[1m#x1B[.../workflow_engine/migration_helpers/test_migrate_rule_action.py#x1B[0m:615: in test_email_migration
    self.assert_actions_migrated_correctly(
#x1B[1m#x1B[.../workflow_engine/migration_helpers/test_migrate_rule_action.py#x1B[0m:201: in assert_actions_migrated_correctly
    self.assert_action_attributes(
#x1B[1m#x1B[.../workflow_engine/migration_helpers/test_migrate_rule_action.py#x1B[0m:172: in assert_action_attributes
    assert action.config.get("target_identifier") is None
#x1B[1m#x1B[31mE   AssertionError: assert '3234013' is None#x1B[0m
#x1B[1m#x1B[31mE    +  where '3234013' = <built-in method get of dict object at 0x7fb93afadac0>('target_identifier')#x1B[0m
#x1B[1m#x1B[31mE    +    where <built-in method get of dict object at 0x7fb93afadac0> = {'target_display': None, 'target_identifier': '3234013', 'target_type': 1}.get#x1B[0m
#x1B[1m#x1B[31mE    +      where {'target_display': None, 'target_identifier': '3234013', 'target_type': 1} = <Action at 0x7fb958f88050: id=74, type=<ActionType.EMAIL: 'email'>>.config#x1B[0m
tests.sentry.workflow_engine.test_integration.TestWorkflowEngineIntegrationFromErrorPostProcess::test_default_workflow
Stack Traces | 5.88s run time
#x1B[1m#x1B[.../sentry/workflow_engine/test_integration.py#x1B[0m:272: in test_default_workflow
    mock_trigger.assert_called_once()
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/unittest/mock.py#x1B[0m:956: in assert_called_once
    raise AssertionError(msg)
#x1B[1m#x1B[31mE   AssertionError: Expected 'apply_async' to have been called once. Called 0 times.#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants