feat(cells) Add silo annotations to email, debug, and plugin views #104034
Conversation
github-actions
bot
added
the
Scope: Backend
We need to mark debug email views as internal. They won't be reachable via cell routing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104034 +/- ##
===========================================
- Coverage 80.62% 80.55% -0.07%
===========================================
Files 9317 9316 -1
Lines 397571 398277 +706
Branches 25392 25361 -31
===========================================
+ Hits 320522 320817 +295
- Misses 76597 77008 +411
Partials 452 452 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| new RegExp('^remote/vercel/oauth$'), | ||
| new RegExp('^$'), | ||
| new RegExp('^support/$'), | ||
| new RegExp('^identity/login/[^/]+/$'), | ||
| new RegExp('^orgredirect/try-business/$'), | ||
| new RegExp('^orgredirect/'), | ||
| new RegExp('^associate/complete/[^/]+/$'), | ||
| new RegExp('^associate/[^/]+/$'), | ||
| new RegExp('^api/0/staff-auth/$'), | ||
| new RegExp('^api/0/signup/$'), | ||
| new RegExp('^api/0/audit-logs/$'), |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
markstory
changed the title
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| @all_silo_view |
There was a problem hiding this comment.
Bug: GitHub integration webhook incorrectly uses all_silo_view
GithubPluginIntegrationsWebhookEndpoint is decorated with @all_silo_view but uses region-scoped models like Repository, Commit, and CommitAuthor through its webhook handlers. According to the PR discussion, this endpoint should use @region_silo_view instead, matching the BitbucketPluginWebhookEndpoint and GithubPluginWebhookEndpoint which correctly use @region_silo_view for the same reason.
Add silo annotations to the debug views, and plugin views. While debug email views are never run in production, having silo annotations on these will allow silo completeness tests to have fewer exceptions.
Refs INFRENG-201