feat(aci): Adjust interval to match max number of buckets #104038
+244
−343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Member
|
picked 90 days on this one now that its available and it used 15m buckets instead of 5 https://sentry-pn5kwbqoj.sentry.dev/monitors/2809015/?statsPeriod=90d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes a slightly different approach to the max buckets problem. Previously, we were:
After this PR, we will adjust the interval to be higher for time ranges that exceed the maximum number of points for the given dataset. This allows us to use the default page filters.
IMO it's better if we adjust the interval based on the time range to keep things consistent and give users flexibility to query wider ranges. This also gets metric detector charts working for issue details without needing to add a custom time range selector there.
Before:
After: