WIP: Tagstore read from Occurrences EAP #104843
Draft
+651
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
thetruecpaul
force-pushed
the
cpaul/eap/tagstoreread
branch
from
2bd5de5 to
159aa88
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #104843 +/- ##
===========================================
+ Coverage 79.21% 80.46% +1.25%
===========================================
Files 9363 9372 +9
Lines 401852 402597 +745
Branches 25833 25833
===========================================
+ Hits 318337 323966 +5629
+ Misses 83073 78189 -4884
Partials 442 442 |
There's a lot of good work & validation in this framework. Let's pick it up and use it for our own ends. This PR adds an implementation of RPCBase for use with Occurrence trace items.
thetruecpaul
force-pushed
the
cpaul/eap/tagstoreread
branch
from
159aa88 to
b3ea29d
Compare
We want to control how reads from Occurrences on EAP happen. Generally, we want it to look like: * We roll out ingestion to some % of a region * (Optional pause to wait for some data) * We roll out double-read to the region * The snuba & EAP results will start different — because EAP doesn't have full retention for the full region yet — but should track to zero differences over time. Then, for each new read we onboard: * Gate reading at all behind the standard rollout * Gate using the data behind the callsite allowlist * Set up a reasonable_match comparator * Land PR. * Observe data for callsite. * Should have 100% reasonable_match rate. * Should have exact_match rate go to 100% over time. * Once exact_match has been at 100% for some time, add callsite to allowlist.
thetruecpaul
force-pushed
the
cpaul/eap/tagstoreread
branch
from
b3ea29d to
97a1bfb
Compare
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup TK, just sharing current state ATP