fix(issue details): Correctly copy issue details for threaded stacktraces #105434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
JoshFerge
reviewed
Jan 5, 2026
Member
JoshFerge
left a comment
JoshFerge
left a comment
There was a problem hiding this comment.
core of the logic looks good to me! will defer to frontend folks on state management, etc.
scttcper
reviewed
Jan 5, 2026
Comment on lines
57
to
60
| const markdownText = useMemo(() => { | ||
| return issueAndEventToMarkdown(group, event, groupSummaryData, autofixData); | ||
| }, [group, event, groupSummaryData, autofixData]); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps -- activeThreadId triggers recomputation when thread changes | ||
| }, [group, event, groupSummaryData, autofixData, activeThreadId]); |
Member
There was a problem hiding this comment.
maybe pass the activeThreadId to issueAndEventToMarkdown so that we don't have to disable this rule
scttcper
approved these changes
Jan 6, 2026
Member
scttcper
left a comment
scttcper
left a comment
There was a problem hiding this comment.
not super excited about the singleton pattern being added to store that id but i'm also not sure a context just for that value would be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Current "Copy As Markdown" button in issue details doesn't handle threaded stacktraces and ignores the user selected thread.
Solution:
Following this commit, added setting and getting of active thread value from ui and included a threads section in the markdown with the relevant stacktrace. Also extracted the formatStacktraceToMarkdown method for easy reuse.
Testing:
Works locally with both button and hotkeys. Tooltip also updates with correct length based on thread selected.
Watchdog thread selected, added portion after change:
Main thread selected, added portion after change:
