Skip to content

chore(preprod): Set default data EAP retention to 13 months #105646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NicoHinderling wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −4
Open

chore(preprod): Set default data EAP retention to 13 months #105646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
635fe87
chore(preprod): Set default data EAP retention to 13 months
NicoHinderling Jan 5, 2026
1e42e15
unit tests
NicoHinderling Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/sentry/preprod/eap/write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
from sentry.utils.arroyo_producer import SingletonProducer, get_arroyo_producer
from sentry.utils.kafka_config import get_topic_definition

THIRTEEN_MONTHS = 396 # 13 months in days
Copy link
Contributor Author

@NicoHinderling NicoHinderling Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the value used in getsentry



def produce_preprod_size_metric_to_eap(
size_metric: PreprodArtifactSizeMetrics,
Expand Down Expand Up @@ -109,7 +111,7 @@ def produce_preprod_size_metric_to_eap(
timestamp=proto_timestamp,
trace_id=trace_id,
received=received,
retention_days=90, # Default retention for preprod data
retention_days=THIRTEEN_MONTHS, # Default retention for preprod data

This comment was marked as outdated.

Sign in to view

attributes={k: anyvalue(v) for k, v in attributes.items() if v is not None},
client_sample_rate=1.0,
server_sample_rate=1.0,
Expand Down Expand Up @@ -217,7 +219,7 @@ def produce_preprod_build_distribution_to_eap(
timestamp=proto_timestamp,
trace_id=trace_id,
received=received,
retention_days=90,
retention_days=THIRTEEN_MONTHS,
attributes={k: anyvalue(v) for k, v in attributes.items() if v is not None},
client_sample_rate=1.0,
server_sample_rate=1.0,
Expand Down
5 changes: 3 additions & 2 deletions tests/sentry/preprod/eap/test_write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from sentry.conf.types.kafka_definition import Topic, get_topic_codec
from sentry.models.commitcomparison import CommitComparison
from sentry.preprod.eap.write import (
THIRTEEN_MONTHS,
produce_preprod_build_distribution_to_eap,
produce_preprod_size_metric_to_eap,
)
Expand Down Expand Up @@ -82,7 +83,7 @@ def test_write_preprod_size_metric_encodes_all_fields_correctly(self, mock_produ
assert trace_item.organization_id == self.organization.id
assert trace_item.project_id == self.project.id
assert trace_item.item_type == TraceItemType.TRACE_ITEM_TYPE_PREPROD
assert trace_item.retention_days == 90
assert trace_item.retention_days == THIRTEEN_MONTHS

attrs = trace_item.attributes

Expand Down Expand Up @@ -231,7 +232,7 @@ def test_write_preprod_build_distribution_encodes_all_fields_correctly(self, moc
assert trace_item.organization_id == self.organization.id
assert trace_item.project_id == self.project.id
assert trace_item.item_type == TraceItemType.TRACE_ITEM_TYPE_PREPROD
assert trace_item.retention_days == 90
assert trace_item.retention_days == THIRTEEN_MONTHS

attrs = trace_item.attributes

Expand Down
Loading