Skip to content

fix(seer onboarding): remove on_command_phrase CR trigger from settings forms #105696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srest2021 merged 5 commits into from
Jan 9, 2026
Merged

fix(seer onboarding): remove on_command_phrase CR trigger from settings forms #105696

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef9b293
dont show on_command_phrase
srest2021 Jan 6, 2026
f61fdbe
make help text more clear
srest2021 Jan 6, 2026
8593880
styling nits
srest2021 Jan 6, 2026
f1ffd2b
revert latest help text change
srest2021 Jan 6, 2026
ee1f6cd
remove unnecessary change; fix in default org settings
srest2021 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions static/gsApp/views/seerAutomation/components/repoDetails/repoDetailsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Form from 'sentry/components/forms/form';
import JsonForm from 'sentry/components/forms/jsonForm';
import {t} from 'sentry/locale';
import {t, tct} from 'sentry/locale';
import {
DEFAULT_CODE_REVIEW_TRIGGERS,
type RepositoryWithSettings,
Expand All @@ -18,6 +18,14 @@ interface Props {
export default function RepoDetailsForm({organization, repoWithSettings}: Props) {
const canWrite = useCanWriteSettings();

const initialTriggers =
repoWithSettings?.settings?.codeReviewTriggers ??
organization.defaultCodeReviewTriggers ??
DEFAULT_CODE_REVIEW_TRIGGERS;
const modifiableTriggers = initialTriggers.filter(
trigger => trigger !== 'on_command_phrase'
);

return (
<Form
allowUndo
Expand All @@ -30,10 +38,7 @@ export default function RepoDetailsForm({organization, repoWithSettings}: Props)
repoWithSettings?.settings?.enabledCodeReview ??
organization.autoEnableCodeReview ??
true,
codeReviewTriggers:
repoWithSettings?.settings?.codeReviewTriggers ??
organization.defaultCodeReviewTriggers ??
DEFAULT_CODE_REVIEW_TRIGGERS,
codeReviewTriggers: modifiableTriggers,
repositoryIds: [repoWithSettings.id],
} satisfies RepositorySettings
}
Expand All @@ -57,13 +62,13 @@ export default function RepoDetailsForm({organization, repoWithSettings}: Props)
{
name: 'codeReviewTriggers',
label: t('Code Review Triggers'),
help: t(
'Reviews can run on demand, whenever a PR is opened, or after each commit is pushed to a PR.'
help: tct(
'Reviews can run whenever a PR is opened, or after each commit is pushed to a PR. Reviews can always be triggered on demand by calling [code:@sentry review].',
{code: <code />}
),
type: 'choice',
multiple: true,
choices: [
['on_command_phrase', t('On Command Phrase')],
['on_ready_for_review', t('On Ready for Review')],
['on_new_commit', t('On New Commit')],
],
Expand Down
Loading