feat(replay): Add pagination to Playlist view #105701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
billyvg
force-pushed
the
billy/replay-add-pagination-to-playlist-tab
branch
from
8fa4636 to
3c3aded
Compare
billyvg
commented
Jan 6, 2026
Comment on lines
+150
to
+160
| {pageLinks ? ( | ||
| <StyledPagination | ||
| pageLinks={pageLinks} | ||
| onCursor={(cursor, path, searchQuery) => { | ||
| navigate({ | ||
| pathname: path, | ||
| query: {...searchQuery, cursor}, | ||
| }); | ||
| }} | ||
| /> | ||
| ) : null} |
Member
Author
There was a problem hiding this comment.
TBD, but if we want scrolling to work properly in playlist tab, we need to embed pagination into the table, otherwise we can't internally scroll the table. since we have:
| alert |
| table |
| pagination |
ideally, alert should be sticky at the top, along with the table headers, and pagination should only be visible when we scroll to the last row in the table.
In order to have table headers sticky, we would need the scroll to be internal to the table, which means the only way to see pagination only when we reach the last row in the table is for pagination to be embedded in the table. Otherwise, we would need pagination to always be visible as well, which is kind of a waste of pixels.
This adds our normal pagination at the end of the replays table in the Playlist view
billyvg
force-pushed
the
billy/replay-add-pagination-to-playlist-tab
branch
from
79f9930 to
85c7fff
Compare
…it is covered by header)
ryan953
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds our normal pagination at the end of the replays table in the Playlist view