feat(eco): Adds a way to surface debug data safely from integration metadata, while excluding sensitive information #106035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e data for debugging
…oviders that have active metadata
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
cathteng
approved these changes
Jan 12, 2026
src/sentry/integrations/base.py
Outdated
| A dictionary containing only the allowlisted metadata fields. | ||
| """ | ||
| allowed_keys = self._get_debug_metadata_keys() | ||
| return {key: value for key, value in self.model.metadata.items() if key in allowed_keys} |
Member
There was a problem hiding this comment.
Should we also return None for keys we expect to exist for debugging but don't actually exist in the metadata?
Member
Author
There was a problem hiding this comment.
Yeah we can, I can invert this logic.
GabeVillalobos
deleted the
gv/add_way_to_surface_non_sensitive_metadata_for_debug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new method called
get_debug_metadata, which returns a filtered metadata field, dictated by the child class's_get_debug_metadata_keys. The latter method acts as an allow list for non-sensitive fields to be logged or surfaced via admin APIs