fix(aci): Better handling for error monitor edit permissions #106050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
force-pushed
the
malwilley/fix/better-handling-for-error-monitor-edit-permissions
branch
from
957663f to
7801b99
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
scttcper
approved these changes
Jan 12, 2026
malwilley
deleted the
malwilley/fix/better-handling-for-error-monitor-edit-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are not allowing most users to click into the error monitor edit page. That's not really necessary since the edit page doesn't actually allow you to edit anything and gives you good information about the necessary settings pages.
In this PR I've opened up the edit button to anyone with ACI permissions. I've also done a little refactoring to make the detector header component more composable which allows us to modify the edit button behavior here.