feat(toolbar): Return the CSRF token into the toolbar auth flow for use #106059
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the csrf token so the toolbar can make POST/PUT requests and make the toolbar read/write.
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…t by django in the response phase, after this view has finished.
billyvg
approved these changes
Jan 12, 2026
| document.cookie = getCookieValue(cookie, window.location.hostname); | ||
| log('Saved a cookie', document.cookie.indexOf(cookie) >= 0); | ||
| } | ||
| if (csrfToken) { |
Member
There was a problem hiding this comment.
Should we log if csrf token isn't found?
Member
Author
There was a problem hiding this comment.
Also important is handling it on the UI side so things gracefully degrade.
There's no Sentry on this page now afaik, we'd need to load in from the CDN, so i'll take that as a followup for this whole html template.
Member
Author
There was a problem hiding this comment.
but we're relying on middleware... so i think the odds of not having it are low. unless it's misconfigured for this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the csrf token so the toolbar can make POST/PUT requests and make the toolbar read/write.