codemod(flex): apply changes for @getsentry/ecosystem #106302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
commented
Jan 14, 2026
| display: flex; | ||
| gap: ${space(1)}; | ||
| `; | ||
| export function ButtonWrapper(props: FlexProps<'span'>) { |
Member
Author
There was a problem hiding this comment.
@cursoragent modify this to omit as prop from flex signature
Contributor
There was a problem hiding this comment.
Perfect! I've successfully modified the ButtonWrapper component to omit the as prop from the Flex signature.
What I did:
- Changed the props type from
FlexProps<'span'>toOmit<FlexProps<'span'>, 'as'> - This resolves the TypeScript error by excluding the
asprop from the component's signature, since it's already hardcoded to"span"in the implementation
The change has been committed and pushed to the codemod-migration/getsentry-ecosystem branch. This should fix the TypeScript CI failure.
Co-authored-by: jonas.badalic <[email protected]>
Co-authored-by: jonas.badalic <[email protected]>
Co-authored-by: jonas.badalic <[email protected]>
Co-authored-by: jonas.badalic <[email protected]>
Co-authored-by: jonas.badalic <[email protected]>
Co-authored-by: jonas.badalic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the flex codemod to files owned by @getsentry/ecosystem.