fix(crons): Enable pointer events on incident indicator #106319
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The incident indicator in the crons monitors timeline was not receiving pointer events, preventing user interaction. This change explicitly sets `pointer-events: auto` to resolve this.
github-actions
bot
added
the
Scope: Frontend
| align-items: center; | ||
| z-index: 2; | ||
| height: 20px; | ||
| pointer-events: auto; |
Member
There was a problem hiding this comment.
what causes us to lose this?
Member
Author
There was a problem hiding this comment.
CronServiceIncidents is rendered inside PositionedGridLineOverlay, which has pointer-events: none
. Its not immediately clear to me why pointer-events: none is necessary there, seems that the rows are still interactive with that rule disabled, potentially for interactions with the header.
Member
Author
There was a problem hiding this comment.
@malwilley any insight here? Looks like that rule was added with be022ad
Member
There was a problem hiding this comment.
Hmm, if you can remove it and everything still works as expected it may have been added erroneously. Feel free to remove on the detector list component
Member
Author
There was a problem hiding this comment.
I'm not quite familiar with all of the features of this view so I'd prefer to go with the conservative approach of changing IncidentIndicator pointer-events to auto for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where pointer events were disabled on the incident indicator in the crons monitor timeline, preventing user interaction with the tooltip/indicator.
Added
pointer-events: autoto theIncidentIndicatorstyled component to enable mouse events on the incident indicator