Skip to content

ref(theme): remove backwards compat shim #106325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
natemoo-re wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −180
Draft

ref(theme): remove backwards compat shim #106325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 0 additions & 173 deletions static/app/utils/theme/compat.tsx
View file
Open in desktop

This file was deleted.

9 changes: 2 additions & 7 deletions static/app/utils/theme/theme.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import type {CSSProperties} from 'react';
import {css} from '@emotion/react';
import {spring, type Transition} from 'framer-motion';

import {withLegacyTokens, type LegacyTokens} from 'sentry/utils/theme/compat';
// eslint-disable-next-line no-restricted-imports
import {darkTheme as baseDarkTheme} from 'sentry/utils/theme/scraps/theme/dark';
// eslint-disable-next-line no-restricted-imports
Expand All @@ -30,7 +29,6 @@ import type {
} from './types';

type Tokens = typeof baseLightTheme.tokens | typeof baseDarkTheme.tokens;
type TokensWithLegacy = Tokens & LegacyTokens;

type MotionDefinition = Record<MotionDuration, string>;

Expand Down Expand Up @@ -558,7 +556,7 @@ export interface SentryTheme
getColorPalette: ReturnType<typeof makeChartColorPalette>;
neutral: string;
};
tokens: TokensWithLegacy;
tokens: Tokens;
}

const ccl = color.categorical.light;
Expand Down Expand Up @@ -1222,8 +1220,6 @@ const lightThemeDefinition = {
...baseLightTheme,
...lightAliases,
...lightShadows,
// @TODO: remove backwards-compatability shim
tokens: withLegacyTokens(baseLightTheme.tokens),
focusRing: (baseShadow = `0 0 0 0 ${baseLightTheme.tokens.background.primary}`) => ({
outline: 'none',
boxShadow: `${baseShadow}, 0 0 0 2px ${baseLightTheme.tokens.focus.default}`,
Expand Down Expand Up @@ -1262,8 +1258,7 @@ export const darkTheme: SentryTheme = {
...baseDarkTheme,
...darkAliases,
...darkShadows,
// @TODO: remove backwards-compatability shim
tokens: withLegacyTokens(baseDarkTheme.tokens),

focusRing: (baseShadow = `0 0 0 0 ${baseDarkTheme.tokens.background.primary}`) => ({
outline: 'none',
boxShadow: `${baseShadow}, 0 0 0 2px ${baseDarkTheme.tokens.focus.default}`,
Expand Down
Loading