-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(occurrences on eap): Implement double reads from EAP for error counts timeseries #107308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(occurrences on eap): Implement double reads from EAP for error counts timeseries #107308
Conversation
…_timeseries_by_project_and_release`
|
bugbot review |
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Show resolved
Hide resolved
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Show resolved
Hide resolved
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Show resolved
Hide resolved
…errors-counts-timeseries
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
src/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py
Show resolved
Hide resolved
…errors-counts-timeseries
| if not release_value_list: | ||
| return [] | ||
|
|
||
| query_string = "type:error" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type:error might be incorrect - we may have some non-error events that still fall under the Dataset.Events category
Implements double reads of occurrences from EAP for
get_errors_counts_timeseries_by_project_and_releaseinsrc/sentry/api/endpoints/release_thresholds/utils/get_errors_counts_timeseries.py.