feat(preprod): Add artifact-type filtering to size status checks#108311
Open
cameroncooke wants to merge 3 commits intomasterfrom
Open
feat(preprod): Add artifact-type filtering to size status checks#108311cameroncooke wants to merge 3 commits intomasterfrom
cameroncooke wants to merge 3 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
Parse status check rule artifact types as explicit enums and apply artifact-matching semantics consistently when selecting compare metrics. Add focused tests for candidate metric and base metric matching helpers to guard against neutral-first-run regressions. Refs EME-808
cameroncooke
force-pushed
the
codex/eme-808-backend-artifact-rules
branch
from
334b6f1 to
ad7fc00
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Fix CI pre-commit lint by applying ruff formatting to the status check filter test file. Refs EME-808
cameroncooke
changed the title
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Replace string artifact type values with RuleArtifactType enums in status check filter tests so backend typing passes. Refs EME-808
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add artifact-type filtering support to preprod size status checks.
Previously rules were effectively evaluated only against main-app metrics. This change introduces explicit rule artifact types and applies them during status check evaluation, so rules can target Main App, Watch App, Android Dynamic Feature, or All artifacts.
Key changes:
Refs EME-808