feat(dashboards): allow interval selection similar to explore#108416
feat(dashboards): allow interval selection similar to explore#108416
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
Makes sense overall, just a few nits!
@narsaynorath wanted to ask you though, it looks like widgets (and maybe dashboards) can specify interval but we don't actually use it? Does that sound right? If yes we should maybe drop that column 🤔
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
bcoe
force-pushed
the
dashboard-interval-selection
branch
from
4ff065c to
18eafcc
Compare
DominikB2014
left a comment
DominikB2014
left a comment
There was a problem hiding this comment.
Looking good! I haven't played around with the ux, but based on the screenshot the interval selector looks like random text on the screen and not a clickable button. Perhaps a dropdown component makes more sense?
bcoe
force-pushed
the
dashboard-interval-selection
branch
from
95702f9 to
db14124
Compare
static/app/views/dashboards/widgetCard/hooks/useReleasesWidgetQuery.tsx
Outdated
Show resolved
Hide resolved
|
I added a Sentry dashboard to keep an eye on durations for API requests from Dashboards pages. Would be good to come back in a few weeks and see if there's been any effect! There probably won't be, but it's good to be sure. |
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
LGTM, just one nit about the test setup!
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| import {determineSeriesSampleCountAndIsSampled} from 'sentry/views/alerts/rules/metric/utils/determineSeriesSampleCount'; | ||
| import {formatSort} from 'sentry/views/explore/contexts/pageParamsContext/sortBys'; | ||
| import {DEFAULT_VISUALIZATION} from 'sentry/views/explore/contexts/pageParamsContext/visualizes'; | ||
| import {useChartInterval} from 'sentry/views/explore/hooks/useChartInterval'; |
There was a problem hiding this comment.
Explore default interval may become too granular
Medium Severity
The shared useChartInterval defaults to USE_SMALLEST, and Explore now imports this hook. If the previous Explore-specific behavior defaulted to a coarser interval, this change can silently increase bucket count and query cost for Explore charts when interval is not set in the URL, potentially impacting latency and rate limits.
There was a problem hiding this comment.
Explore also used USE_SMALLEST so I do not believe this is an issue.
Allows for interval selection similar to the behaviour of individual charts in explore.
3 participants
Allows for interval selection similar to the behaviour of individual charts on the explore pages.
TODO: