ref(replays): clamp connected error query dates to org retention period#108428
Open
ref(replays): clamp connected error query dates to org retention period#108428
Conversation
Uses outside_retention_with_modified_start to skip fetching trace-connected errors when the replay's date range falls entirely outside the organization's retention window.
github-actions
bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
In
rpc_get_replay_summary_logs, the start/end dates used to fetch trace-connected errors were previously hardcoded to a 90-day window relative todatetime.now(UTC), ignoring the organization's actual retention period.This change:
default_start_end_dates()(already used for the initial replay lookup), so the window is consistent throughout the functionoutside_retention_with_modified_startto clampstartto the organization's retention boundary before querying connected errorsfetch_trace_connected_errorsSnuba query entirely when the clampedstart >= end(i.e., the replay falls entirely outside retention), avoiding a query that would return no resultsFixes SENTRY-5AEE
Fixes SENTRY-5AEF