Skip to content

fix(performance): Fix EAP transaction summary method filter and duration breakdown chart#108483

Merged
mjq merged 5 commits intomasterfrom
mjq/2026-02-17/convert-transaction-summary-to-use-eap
Feb 23, 2026
Merged

fix(performance): Fix EAP transaction summary method filter and duration breakdown chart#108483
mjq merged 5 commits intomasterfrom
mjq/2026-02-17/convert-transaction-summary-to-use-eap

Conversation

@mjq
Copy link
Member

@mjq mjq commented Feb 18, 2026

Fix two issues with the EAP transaction summary page and improve the duration breakdown chart.

Method filter mismatch

When the performance-transaction-summary-eap flag is enabled, dashboard widget links filter by request.method (the EAP field name), but the transaction summary search bar didn't recognize it as a valid key. This caused an "Invalid key" error when navigating from dashboards. Now the search bar accepts request.method when EAP is enabled, and the dashboard link uses the correct field name based on the flag.

Duration breakdown chart

The EAP version of the duration breakdown chart now matches the regular (non-EAP) version:

  • removed the extra p90 percentile
  • uses high-fidelity time intervals
  • aliases series names to match the standard format (e.g. p50() instead of p50(span.duration))
  • persists legend selection via the unselectedSeries URL query parameter.

Note that this is now a line chart instead of an area chart. As per our Choosing The Plot Type guide:

Only use area charts if you want to plot multiple series and those series represent components of a total. For example, area charts are a good choice to show time spent, broken down by span operation. They are not a good choice for plotting a single duration time series. Area charts should be stacked!

Screens

Old Transaction Summary:
Screenshot 2026-02-23 at 10 53 34

EAP version:
Screenshot 2026-02-23 at 10 49 01

Closes DAIN-1226

mjq and others added 3 commits February 18, 2026 11:01
Switch the EAP Duration Breakdown chart from a line chart to a stacked
area chart, remove the extra p90 percentile, use high-fidelity time
intervals, alias series names to match the regular chart format (e.g.
`p50()` instead of `p50(span.duration)`), and add URL-based legend
selection persistence via the `unselectedSeries` query parameter.

Co-Authored-By: Claude <noreply@anthropic.com>
…nabled

Use `request.method` instead of `http.method` in the transaction
summary link filter when the `performance-transaction-summary-eap`
flag is enabled, so dashboard filters match the EAP-based summary page.

Co-Authored-By: Claude <noreply@anthropic.com>
…r supported keys

When the EAP flag is enabled, dashboard widget links filter by
request.method instead of http.method. The search query builder
didn't recognize request.method as a valid key, causing an
"Invalid key" error on the transaction summary page.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 18, 2026
@mjq mjq marked this pull request as ready for review February 18, 2026 20:02
@mjq mjq requested review from a team as code owners February 18, 2026 20:03
…ization

Add `?? []` fallback to the plottables mapping so it always resolves
to `Plottable[]` even if `spanSeriesData` is nullish. While the
isPending/isError guard prevents this in practice, this is the right
defensive pattern and matches codebase conventions.

Co-Authored-By: Claude <noreply@anthropic.com>
The duration breakdown chart plots percentiles of a single duration
metric, not components of a total. Per the TimeSeriesWidgetVisualization
guidelines: "Only use area charts if you want to plot multiple series
and those series represent components of a total. [...] They are not a
good choice for plotting a single duration time series."

Reverts the area chart change from 58f0bbc.

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@linear
Copy link

linear bot commented Feb 23, 2026

@mjq mjq merged commit de508ab into master Feb 23, 2026
69 checks passed
@mjq mjq deleted the mjq/2026-02-17/convert-transaction-summary-to-use-eap branch February 23, 2026 17:45
mchen-sentry pushed a commit that referenced this pull request Feb 24, 2026
…ion breakdown chart (#108483)

Fix two issues with the EAP transaction summary page and improve the
duration breakdown chart.

## Method filter mismatch

When the `performance-transaction-summary-eap` flag is enabled,
dashboard widget links filter by `request.method` (the EAP field name),
but the transaction summary search bar didn't recognize it as a valid
key. This caused an "Invalid key" error when navigating from dashboards.
Now the search bar accepts `request.method` when EAP is enabled, and the
dashboard link uses the correct field name based on the flag.

## Duration breakdown chart

The EAP version of the duration breakdown chart now matches the regular
(non-EAP) version:
- removed the extra p90 percentile
- uses high-fidelity time intervals
- aliases series names to match the standard format (e.g. `p50()`
instead of `p50(span.duration)`)
- persists legend selection via the `unselectedSeries` URL query
parameter.

Note that this is now a line chart instead of an area chart. As per our
[Choosing The Plot
Type](https://sentry.sentry.io/stories/product/views/dashboards/widgets/timeserieswidget/timeserieswidgetvisualization/#choosing-the-plot-type)
guide:

> Only use area charts if you want to plot multiple series and those
series represent components of a total. For example, area charts are a
good choice to show time spent, broken down by span operation. They are
not a good choice for plotting a single duration time series. Area
charts should be stacked!

## Screens

Old Transaction Summary:
<img width="1223" height="296" alt="Screenshot 2026-02-23 at 10 53 34"
src="https://github.com/user-attachments/assets/2608f2e0-b2ac-40fb-a53d-a0a400b46489"
/>


EAP version:
<img width="1225" height="312" alt="Screenshot 2026-02-23 at 10 49 01"
src="https://github.com/user-attachments/assets/47d90d51-bb87-40a6-a7ff-4a63b31b987a"
/>

Closes DAIN-1226

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-code-assisted Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants