Skip to content

fix(seer): Populate missing IssueDetails fields for explorer_index #109213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shruthilayaj merged 3 commits into from
Feb 24, 2026
Merged

fix(seer): Populate missing IssueDetails fields for explorer_index #109213

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04456a6
fix(seer): Populate missing IssueDetails fields for explorer_index
sentry[bot] Feb 24, 2026
a661c2a
Apply suggestions from code review
shruthilayaj Feb 24, 2026
4311357
test(seer): Add tests for IssueDetails new fields in get_issues_for_t…
shruthilayaj Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/sentry/seer/explorer/index_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,13 +505,18 @@

serialized_event = serialize(full_event, user=None, serializer=EventSerializer())

group_metadata = group.data.get("metadata", {})

Check warning on line 508 in src/sentry/seer/explorer/index_data.py

View check run for this annotation

@sentry/warden / warden: sentry-backend-bugs

AttributeError when group.data is None 

The code calls `group.data.get("metadata", {})` but the Group model's `data` field is defined as `LegacyTextJSONField(null=True)` (line 669 of group.py), meaning it can be None. When `group.data` is None, this line will raise `AttributeError: 'NoneType' object has no attribute 'get'`. This matches the pattern from SENTRY-3Z3P (NoneType item assignment) where code assumes a value is a dict when it can be None.
issue_data_list.append(
IssueDetails(
id=group.id,
title=group.title,
short_id=group.qualified_short_id,
culprit=group.culprit,
transaction=full_event.transaction,
events=[serialized_event],
project=group.project_id,
filename=group_metadata.get("filename"),
function=group_metadata.get("function"),
)
)

Expand Down
4 changes: 4 additions & 0 deletions src/sentry/seer/sentry_data_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,15 @@ class TraceProfiles(BaseModel):
class IssueDetails(BaseModel):
id: int
title: str
short_id: str | None = None
culprit: str | None
transaction: str | None
events: list[dict[str, Any]]
metadata: dict[str, Any] = {}
message: str = ""
project: int | None = None
filename: str | None = None
function: str | None = None


class TransactionIssues(BaseModel):
Expand Down
Loading