chore(deps): bump react-router-dom from 6.30.3 to 7.13.1#109276
chore(deps): bump react-router-dom from 6.30.3 to 7.13.1#109276dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "react-mentions": "4.4.10", | ||
| "react-popper": "^2.3.0", | ||
| "react-router-dom": "6.30.3", | ||
| "react-router-dom": "7.13.1", |
There was a problem hiding this comment.
Major version bump breaks Sentry router v6 integration
High Severity
Bumping react-router-dom from 6.x to 7.x is a major version upgrade, but the codebase still uses Sentry's v6-specific integrations: wrapCreateBrowserRouterV6 and reactRouterV6BrowserTracingIntegration (found in static/app/main.tsx, static/app/views/integrationPipeline/pipelineView.tsx, static/gsAdmin/init.tsx, and static/app/bootstrap/initializeSdk.tsx). Sentry documents separate wrapCreateBrowserRouterV7 and reactRouterV7BrowserTracingIntegration wrappers for React Router v7. Using v6-specific wrappers with a v7 router will likely break browser tracing or cause runtime errors, since v7 removed the @remix-run/router dependency and restructured internals. Additionally, v7 enforces all v6 future flags by default (e.g. v7_relativeSplatPath, v7_startTransition), which could alter routing behavior without corresponding code updates.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "react-mentions": "4.4.10", | ||
| "react-popper": "^2.3.0", | ||
| "react-router-dom": "6.30.3", | ||
| "react-router-dom": "7.13.1", |
There was a problem hiding this comment.
Bug: The application uses Sentry's react-router-dom v6 integration functions (wrapCreateBrowserRouterV6) with react-router-dom v7, which will cause a crash on startup.
Severity: CRITICAL
Suggested Fix
Update the Sentry integration to be compatible with react-router-dom v7. Replace calls to wrapCreateBrowserRouterV6 with wrapCreateBrowserRouterV7 and reactRouterV6BrowserTracingIntegration with reactRouterV7BrowserTracingIntegration in files like static/app/main.tsx, static/gsAdmin/init.tsx, and static/app/bootstrap/initializeSdk.tsx.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L168
Potential issue: The pull request upgrades `react-router-dom` from v6 to v7 but fails to
update the Sentry integration functions. The code continues to call
`wrapCreateBrowserRouterV6` and `reactRouterV6BrowserTracingIntegration`, which are
specific to `react-router-dom` v6. According to Sentry's documentation, v7 requires
`wrapCreateBrowserRouterV7` and `reactRouterV7BrowserTracingIntegration`. This
incompatibility will cause a runtime error when the application attempts to initialize
the router, preventing the application from loading.
Did we get this right? 👍 / 👎 to inform future reviews.
|
Dependabot can't authenticate to a private package registry. Because of this, Dependabot cannot update this pull request. |
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 6.30.3 to 7.13.1. - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/react-router-dom@7.13.1/packages/react-router-dom) --- updated-dependencies: - dependency-name: react-router-dom dependency-version: 7.13.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/react-router-dom-7.13.1
branch
from
34e58bc to
4ecd20d
Compare
Bumps react-router-dom from 6.30.3 to 7.13.1.
Release notes
Sourced from react-router-dom's releases.
Changelog
Sourced from react-router-dom's changelog.
... (truncated)
Commits
aa3f078chore: Update version for release (#14829)3207a5cchore: Update version for release (pre) (#14814)5557ba3chore: Update version for release (#14749)62c6e0echore: Update version for release (pre) (#14738)26653a6chore: Update version for release (#14712)7ac2346chore: Update version for release (pre) (#14709)b34a9cdchore: Update version for release (#14668)48b1be4chore: Update version for release (pre) (#14662)ff50507Update monorepo internal React deps (#14639)c257ee1feat(rsc): add support for custom entry files in RSC Framework Mode (#14643)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)