chore: convert ESLint files from .js/.mjs to .ts by JoshuaKGoldberg · Pull Request #109310 · getsentry/sentry

JoshuaKGoldberg · 2026-02-25T12:44:45Z

Directly changes files from .mjs to ~~.mts. I would have preferred the cleaner .ts but that will require adding "type": "module" to package.json, which is more work (which would be a great followup!).~~ .ts, building on #109319's switching the package to be ESM by default. Imports are now TypeScript-style extension-less ones.

Now that the plugin's files are typed, this applies a few types cleanups:

Uses typescript-eslint's RuleCreator to create rules, which gives nicer typings than the built-in ESLint Rule
Updates node types from estree (only vanilla JS types) to @typescript-eslint/estree (full TS node types)
Converts JSDoc types to full TypeScript syntax

This PR should have no changes to the lint rules' behavior. The only runtime code changes are for deleting unused parameters.

Fixes https://linear.app/getsentry/issue/ENG-6930/convert-eslint-files-from-jsmjs-to-ts-and-add-types

github-actions · 2026-02-25T13:16:42Z

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

tsconfig.json

JoshuaKGoldberg · 2026-02-25T14:00:31Z

static/eslint/eslintPluginScraps/src/rules/no-core-import.ts

  meta: {
    type: 'problem',
    docs: {
      description: `Disallow imports from "${FORBIDDEN_PATH}" and autofix to "${REPLACEMENT_PATH}".`,
-      recommended: true,


This was typescript-eslint/typescript-eslint#8695 -> typescript-eslint/typescript-eslint#9025. The only "required" field for meta.docs is description, and arguably even that isn't really used anywhere. Requiring docs.recommended in earlier versions of typescript-eslint was a types bug.

static/eslint/eslintPluginScraps/src/rules/no-core-import.ts

static/eslint/eslintPluginScraps/src/ast/extractor/theme.ts

static/eslint/eslintPluginScraps/src/rules/no-token-import.mts

JoshuaKGoldberg · 2026-02-25T14:07:54Z

static/eslint/eslintPluginScraps/src/rules/use-semantic-token.ts

-
-  create(context) {
+  defaultOptions: [{}],
+  create(context, [options = {}]) {


typescript-eslint's RuleCreator has a nice little benefit of adding in some options defaulting & merging. https://typescript-eslint.io/developers/custom-rules/#handling-rule-options

.pre-commit-config.yaml

package.json

JoshuaKGoldberg · 2026-02-25T14:12:17Z

static/eslint/eslintPluginScraps/src/ast/extractor/index.mts

 */
-export function shouldAnalyze(context) {
+export function shouldAnalyze(context: TSESLint.RuleContext<string, unknown[]>) {
  const sourceCode = context.sourceCode ?? context.getSourceCode();


[Question] context.getSourceCode() is deprecated. context.sourceCode always exists in the one ESLint version we use. I don't know of a need for a fallback. Was this kept in for a specific reason?

i doubt it. let’s trust the types and remove it 👍

package.json

static/eslint/eslintPluginScraps/src/rules/no-token-import.mts

static/eslint/eslintPluginScraps/src/rules/no-core-import.spec.ts

JoshuaKGoldberg · 2026-02-25T14:48:30Z

Converting to draft while I address cursor's feedback.

Edit: and TkDodo's

TkDodo

great work, thank you 🙏

static/eslint/eslintPluginScraps/src/ast/extractor/css-prop.ts

TkDodo · 2026-02-25T14:43:27Z

static/eslint/eslintPluginScraps/src/ast/extractor/index.mts

 */
-export function shouldAnalyze(context) {
+export function shouldAnalyze(context: TSESLint.RuleContext<string, unknown[]>) {
  const sourceCode = context.sourceCode ?? context.getSourceCode();


i doubt it. let’s trust the types and remove it 👍

.pre-commit-config.yaml

tsconfig.json

…ken's (#109326) Similar to #109310, changes the test extensions from `*.spec.mjs` to `*.spec.js`. The `m` is unnecessary because Jest is configured to treat their syntax as ESM either way. `static/eslint/eslintPluginScraps/src/rules/use-semantic-token.spec.js` had some failures in the helper-function-generated invalid cases: * Most were using the `invalidProperty` message ID instead of `invalidPropertyWithSuggestion`, and missing `data.suggestedCategory` * A few were actually not invalid at all and had zero errors

I noticed while working on #109310 that the latest version of [`@typescript-eslint/prefer-optional-chain`](https://typescript-eslint.io/rules/prefer-optional-chain) wasn't being used. Some code snippets like this weren't being reported: ```ts if (apple && apple.banana === "cherry") { ``` That was fixed by typescript-eslint/typescript-eslint#11533. This PR bumps typescript-eslint to the latest version and fixes new lint rule reports. It was mostly prefer-optional-chain reports; others are noted inline.

JoshuaKGoldberg · 2026-03-02T17:47:22Z

static/eslint/eslintPluginScraps/src/rules/restrict-jsx-slot-children.ts

+function getDisplayName(nameNode: TSESTree.JSXTagNameExpression) {
  if (nameNode.type === 'JSXMemberExpression') {
-    return `${nameNode.object.name}.${nameNode.property.name}`;
+    return `${(nameNode.object as TSESTree.JSXIdentifier).name}.${nameNode.property.name}`;


nameNode.object as TSESTree.JSXIdentifier

This might be a potential bug in the rule: nameNode.object is typed as type JSXTagNameExpression = JSXIdentifier | JSXMemberExpression | JSXNamespacedName;. JSXMemberExpression doesn't have a .name; JSXNamespacedName's .name is a JSXIdentifier rather than the expected string.

Sounds legit—are you able to update this to handle the actual type more defensively?

Done!

I used the fancy AST_NODE_TYPES enum from typescript-eslint too.

I split this out into #109725.

JoshuaKGoldberg · 2026-03-02T18:36:21Z

static/eslint/eslintPluginScraps/src/rules/restrict-jsx-slot-children.ts

        if (slotState.has(propName)) {
          throw new TypeError(
-            `Duplicate prop configuration for: ${propName} in slot ${slot.componentNames.join(', ')}`
+            `Duplicate prop configuration for: ${propName} in slot ${Array.from(state.componentNames).join(', ')}`


TypeScript pointed out that slot.componentNames is optional. Was this meant to be state.componentNames?

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

static/eslint/eslintPluginScraps/src/rules/restrict-jsx-slot-children.ts

natemoo-re

Just a few notes that would be good to address before merge, but not worth blocking! Great work on this 🙌

static/eslint/eslintPluginScraps/src/ast/extractor/theme.ts

natemoo-re · 2026-03-02T18:51:07Z

static/eslint/eslintPluginScraps/src/rules/restrict-jsx-slot-children.ts

+function getDisplayName(nameNode: TSESTree.JSXTagNameExpression) {
  if (nameNode.type === 'JSXMemberExpression') {
-    return `${nameNode.object.name}.${nameNode.property.name}`;
+    return `${(nameNode.object as TSESTree.JSXIdentifier).name}.${nameNode.property.name}`;


Sounds legit—are you able to update this to handle the actual type more defensively?

natemoo-re · 2026-03-02T18:51:51Z

static/eslint/eslintPluginScraps/src/rules/restrict-jsx-slot-children.ts

            elementName = nameNode.name;
          } else if (nameNode.type === 'JSXMemberExpression') {
-            elementName = `${nameNode.object.name}.${nameNode.property.name}`;
+            elementName = `${(nameNode.object as TSESTree.JSXIdentifier).name}.${nameNode.property.name}`;


Same issue here?

natemoo-re · 2026-03-02T18:53:10Z

static/eslint/eslintPluginSentry/no-static-translations.ts

        context.report({
          node: translationArg,
-          message: 'td() must use ATTRIBUTE_METADATA[key].brief from @sentry/conventions',
+          messageId: 'forbidden',


Did we lose the message here?

No, this message duplicates the forbidden message ID:

sentry/static/eslint/eslintPluginSentry/no-static-translations.ts

Line 13 in 8d06a5b

forbidden: 'td() must use ATTRIBUTE_METADATA[key].brief from @sentry/conventions',

message is an old legacy ESLint property that isn't even in the TSESLint types.

linear · 2026-03-02T22:20:18Z

ENG-6930 Convert ESLint files from .js/.mjs to .ts and add types

…9725) Followup to #109310: modifies the logic in `restrict-jsx-slot-children` to: * Behavior: handle namespaces and property accesses for JSX tags * Internal: unified `getDisplayName` and the ad hoc stringification in the `JSXAttribute` visitor I split this out into its own PR because the way I wrote `getDisplayName` triggered some reports from ESLint that I wanted to ask about. Fixes https://linear.app/getsentry/issue/ENG-6933/followup-refactor-restrict-jsx-slot-childrens-getdisplayname

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 25, 2026

JoshuaKGoldberg force-pushed the eslint-plugin-scraps-typed branch from 45c26ec to 6dc8082 Compare February 25, 2026 12:54

vercel bot deployed to Preview February 25, 2026 12:57 View deployment

JoshuaKGoldberg force-pushed the eslint-plugin-scraps-typed branch from 6dc8082 to 21c9406 Compare February 25, 2026 13:12

vercel bot deployed to Preview February 25, 2026 13:15 View deployment

JoshuaKGoldberg force-pushed the eslint-plugin-scraps-typed branch from 21c9406 to 877d1ae Compare February 25, 2026 13:16

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 25, 2026

vercel bot deployed to Preview February 25, 2026 13:19 View deployment