Conversation
Adds a callout section for OpenTelemetry Drains and Forwarders to the traces onboarding page, matching the style and language from the logs empty state. The callout includes links to documentation for Vercel, Heroku, and the OpenTelemetry Collector. Co-authored-by: David Cramer <dcramer@users.noreply.github.com>
Adds test to verify that the OpenTelemetry Drains and Forwarders callout is displayed in the traces onboarding page. Co-authored-by: David Cramer <dcramer@users.noreply.github.com>
…allout Co-authored-by: David Cramer <dcramer@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
|
||
| const TraceDrainsLinkWrapper = styled('div')` | ||
| padding-top: ${space(2)}; | ||
| `; |
There was a problem hiding this comment.
New styled component where Container core component suffices
Low Severity
TraceDrainsLinkWrapper is a newly added styled('div') call that only applies padding-top: ${space(2)}. The Container core component from @sentry/scraps/layout supports a paddingTop prop (confirmed by reading its implementation), and space(2) maps to "xl". This could be replaced with <Container paddingTop="xl">, following the project guideline to use core components over Emotion styled components.
Triggered by project rule: Frontend guidelines
2 participants
Removes the Heroku example from the OpenTelemetry Drains callout on the traces empty state page, as Heroku is no longer a relevant platform for this context.
The callout now reads: "You can use OpenTelemetry Drains to send traces from platforms like Vercel, or via the OpenTelemetry Collector."
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Slack Thread