feat(metric-issues): Add attribute comparisons section (for span queries)#109627
Open
malwilley wants to merge 5 commits intomalwilley/explore-attr-compfrom
Open
feat(metric-issues): Add attribute comparisons section (for span queries)#109627malwilley wants to merge 5 commits intomalwilley/explore-attr-compfrom
malwilley wants to merge 5 commits intomalwilley/explore-attr-compfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
static/app/views/issueDetails/streamline/sidebar/metricDetectorTriggeredSection.tsx
Show resolved
Hide resolved
| margin-right: ${p => p.theme.space.sm}; | ||
| flex-shrink: 0; | ||
| } | ||
| `; |
Contributor
There was a problem hiding this comment.
Duplicated styled component already exists in feature area
Low Severity
LegendHint is an exact duplicate of the SelectionHint styled component in cohortComparisonContent.tsx from the same attributeBreakdowns feature area. This file already imports several shared items from that directory (Chart, COHORT_2_COLOR, AttributeBreakdownsComponent), so this component could be exported from the shared styles.tsx module rather than redefined.
scttcper
reviewed
Feb 28, 2026
| const openPeriodEndMs = new Date(openPeriodEnd).getTime(); | ||
| const baselineStart = useMemo( | ||
| () => new Date(openPeriodStartMs - BASELINE_DAYS * 24 * 60 * 60 * 1000), | ||
| [openPeriodStartMs] |
Member
There was a problem hiding this comment.
the date ref here will update on every render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ISWF-901
Depends on #109515 (merge that first), which allows the attribute comparison components to be reused here.
Can go to demo org for plenty of examples: https://demo.dev.getsentry.net:7999/issues/6755986934/