chore: Remove project template endpoints by markstory · Pull Request #109632 · getsentry/sentry

markstory · 2026-02-28T01:00:09Z

We didn't ever finish off this feature and it has languished for a many months. With the OTLP taking a different route, I don't see us using ProjectTemplates any time soon.

Remove the endpoints and tests as a first step, next I'll remove the models.

We didn't ever finish off this feature and it has languished for a many months. Remove the endpoints and tests as a first step, next I'll remove the models.

sentry · 2026-02-28T01:02:24Z

src/sentry/testutils/factories.py


        return project

-    @staticmethod
-    @assume_test_silo_mode(SiloMode.REGION)
-    def create_project_template(project=None, organization=None, **kwargs) -> ProjectTemplate:
-        if not kwargs.get("name"):
-            kwargs["name"] = petname.generate(2, " ", letters=10).title()
-
-        with transaction.atomic(router.db_for_write(Project)):
-            project_template = ProjectTemplate.objects.create(organization=organization, **kwargs)
-
-        return project_template
-
    @staticmethod
    @assume_test_silo_mode(SiloMode.CONTROL)
    def create_data_access_grant(**kwargs):


Bug: The ProjectOptionsTests test class calls the create_project_template() method in its setUp() function, but this method has been removed from the test utility classes, which will cause an AttributeError.
_{Severity: CRITICAL}

Suggested Fix

The ProjectOptionsTests class and its usage of create_project_template() should be removed or updated. Since the functionality related to project templates is being removed, the associated tests are likely no longer necessary and should be deleted.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: src/sentry/testutils/factories.py#L587-L592 Potential issue: The pull request removes the test helper method `create_project_template()` from `src/sentry/testutils/factories.py` and `src/sentry/testutils/fixtures.py`. However, the test class `ProjectOptionsTests` in `tests/sentry/models/test_project.py` still invokes this method within its `setUp()` function. Because the test class inherits from `TestCase`, which uses the `Fixtures` class, the call to the now-nonexistent `self.create_project_template()` will raise an `AttributeError`. This will cause all tests within the `ProjectOptionsTests` suite to fail during setup, preventing them from running.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

cursor · 2026-02-28T01:02:36Z

src/sentry/testutils/fixtures.py

            kwargs["teams"] = [self.team]
        return Factories.create_project(**kwargs)

-    def create_project_template(self, **kwargs) -> ProjectTemplate:


Removed factory method still used in existing test

High Severity

The create_project_template helper was removed from both Factories and Fixtures, but tests/sentry/models/test_project.py line 654 still calls self.create_project_template() in the ProjectOptionsTests.setUp() method. This will cause an AttributeError at test runtime, breaking the entire ProjectOptionsTests test class (including test_get_option, test_get_template_option, test_get_option__override_template, and test_get_option__without_template).

Additional Locations (1)

src/sentry/testutils/factories.py#L579-L589

cursor · 2026-02-28T01:02:36Z

src/sentry/testutils/factories.py


        return project

-    @staticmethod


Orphaned endpoint file imports from deleted serializer module

Medium Severity

src/sentry/api/endpoints/project_templates_index.py still exists and imports ProjectTemplateSerializer and ProjectTemplateWriteSerializer from the now-deleted src/sentry/api/serializers/models/project_template.py. The URL route was removed and nothing imports this file anymore, but it's orphaned dead code with a broken import that will error if anyone tries to use or import it.

github-actions · 2026-02-28T01:03:01Z

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-02-28T01:05:18Z

src/sentry/api/urls.py

 from sentry.api.endpoints.project_overview import ProjectOverviewEndpoint
 from sentry.api.endpoints.project_stacktrace_coverage import ProjectStacktraceCoverageEndpoint
 from sentry.api.endpoints.project_statistical_detectors import ProjectStatisticalDetectors
-from sentry.api.endpoints.project_template_detail import OrganizationProjectTemplateDetailEndpoint


Orphaned endpoint file left with broken imports

Medium Severity

The PR deletes project_template_detail.py, the serializer project_template.py, and removes both URL registrations from urls.py, but leaves project_templates_index.py in the codebase. That orphaned file imports from the now-deleted sentry.api.serializers.models.project_template, so any attempt to import it will fail. Since the PR's stated goal is to remove the project template endpoints, this file appears to have been missed.

github-actions · 2026-02-28T01:24:53Z

Backend Test Failures

Failures on ec1b6c5 in this run:

tests/sentry/models/test_project.py::ProjectOptionsTests::test_get_option__without_template — log

tests/sentry/models/test_project.py:654: in setUp
    self.project_template = self.create_project_template(organization=self.project.organization)
E   AttributeError: 'ProjectOptionsTests' object has no attribute 'create_project_template'. Did you mean: 'create_project_rule'?

tests/sentry/test_devimports.py::test_startup_imports[sentry] — log

tests/sentry/test_devimports.py:122: in test_startup_imports
    validate_package(pkg, EXCLUDED, XFAIL)
tests/sentry/test_devimports.py:117: in validate_package
    raise AssertionError(ret.stdout)
E   AssertionError: error importing sentry.api.endpoints.project_templates_index:
E   
E   Traceback (most recent call last):
E     File "<string>", line 35, in <module>
E       __import__(name)
E       ~~~~~~~~~~^^^^^^
E     File "<string>", line 15, in _import
E       return orig(name, globals=globals, locals=locals, fromlist=fromlist, level=level)
E     File "/home/runner/work/sentry/sentry/src/sentry/api/endpoints/project_templates_index.py", line 13, in <module>
E       from sentry.api.serializers.models.project_template import (
E       ...<2 lines>...
E       )
E     File "<string>", line 15, in _import
E       return orig(name, globals=globals, locals=locals, fromlist=fromlist, level=level)
E   ModuleNotFoundError: No module named 'sentry.api.serializers.models.project_template'

tests/sentry/models/test_project.py::ProjectOptionsTests::test_get_option — log

tests/sentry/models/test_project.py:654: in setUp
    self.project_template = self.create_project_template(organization=self.project.organization)
E   AttributeError: 'ProjectOptionsTests' object has no attribute 'create_project_template'. Did you mean: 'create_project_rule'?

tests/sentry/models/test_project.py::ProjectOptionsTests::test_get_option__override_template — log

tests/sentry/models/test_project.py:654: in setUp
    self.project_template = self.create_project_template(organization=self.project.organization)
E   AttributeError: 'ProjectOptionsTests' object has no attribute 'create_project_template'. Did you mean: 'create_project_rule'?

tests/sentry/models/test_project.py::ProjectOptionsTests::test_get_option__without_template_and_value — log

tests/sentry/models/test_project.py:654: in setUp
    self.project_template = self.create_project_template(organization=self.project.organization)
E   AttributeError: 'ProjectOptionsTests' object has no attribute 'create_project_template'. Did you mean: 'create_project_rule'?

chore: Remove project template endpoints

1becc93

We didn't ever finish off this feature and it has languished for a many months. Remove the endpoints and tests as a first step, next I'll remove the models.

markstory requested review from a team as code owners February 28, 2026 01:00

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 28, 2026

markstory requested a review from a team February 28, 2026 01:00

vercel bot deployed to Preview February 28, 2026 01:01 View deployment

sentry bot reviewed Feb 28, 2026

View reviewed changes

cursor bot reviewed Feb 28, 2026

View reviewed changes

🛠️ Sync API Urls to TypeScript

3f4388e

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 28, 2026

cursor bot reviewed Feb 28, 2026

View reviewed changes

vercel bot deployed to Preview February 28, 2026 01:05 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Remove project template endpoints#109632

chore: Remove project template endpoints#109632
markstory wants to merge 2 commits intomasterfrom
chore-remove-projecttemplate

markstory commented Feb 28, 2026

Uh oh!

sentry bot Feb 28, 2026

Uh oh!

cursor bot Feb 28, 2026

Uh oh!

cursor bot Feb 28, 2026

Uh oh!

github-actions bot commented Feb 28, 2026

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Feb 28, 2026

Uh oh!

github-actions bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

markstory commented Feb 28, 2026

Uh oh!

sentry bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 28, 2026

Choose a reason for hiding this comment

Removed factory method still used in existing test

Uh oh!

cursor bot Feb 28, 2026

Choose a reason for hiding this comment

Orphaned endpoint file imports from deleted serializer module

Uh oh!

github-actions bot commented Feb 28, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 28, 2026

Choose a reason for hiding this comment

Orphaned endpoint file left with broken imports

Uh oh!

github-actions bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Backend Test Failures

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions bot commented Feb 28, 2026 •

edited

Loading